Skip to content

Fix add_files_from_table due to wrong column count condition #26774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

Fix add_files_from_table due to wrong column count condition #26774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1700,8 +1700,8 @@ private Optional<ConnectorTableExecuteHandle> getTableHandleForAddFilesFromTable
Table icebergTable = catalog.loadTable(session, tableHandle.getSchemaTableName());

checkProcedureArgument(
icebergTable.schemas().size() >= sourceTable.getDataColumns().size(),
"Target table should have at least %d columns but got %d", sourceTable.getDataColumns().size(), icebergTable.schemas().size());
icebergTable.schema().columns().size() >= sourceTable.getDataColumns().size(),
"Target table should have at least %d columns but got %d", sourceTable.getDataColumns().size(), icebergTable.schema().columns().size());
checkProcedureArgument(
icebergTable.spec().fields().size() == sourceTable.getPartitionColumns().size(),
"Numbers of partition columns should be equivalent. target: %d, source: %d", icebergTable.spec().fields().size(), sourceTable.getPartitionColumns().size());
Expand Down
6 changes: 3 additions & 3 deletions ...iceberg/src/test/java/io/trino/plugin/iceberg/procedure/TestIcebergAddFilesProcedure.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,12 +124,12 @@ private void testAddFilesDifferentFileFormat(String hiveFormat, String icebergFo
String hiveTableName = "test_add_files_" + randomNameSuffix();
String icebergTableName = "test_add_files_" + randomNameSuffix();

assertUpdate("CREATE TABLE iceberg.tpch." + icebergTableName + " WITH (format = '" + icebergFormat + "') AS SELECT 1 x", 1);
assertUpdate("CREATE TABLE hive.tpch." + hiveTableName + " WITH (format = '" + hiveFormat + "') AS SELECT 2 x", 1);
assertUpdate("CREATE TABLE iceberg.tpch." + icebergTableName + " WITH (format = '" + icebergFormat + "') AS SELECT 1 x, 2 y", 1);
assertUpdate("CREATE TABLE hive.tpch." + hiveTableName + " WITH (format = '" + hiveFormat + "') AS SELECT 3 x, 4 y", 1);

assertUpdate("ALTER TABLE " + icebergTableName + " EXECUTE add_files_from_table('tpch', '" + hiveTableName + "')");

assertQuery("SELECT * FROM " + icebergTableName, "VALUES 1, 2");
assertQuery("SELECT * FROM " + icebergTableName, "VALUES (1, 2), (3, 4)");

assertUpdate("DROP TABLE hive.tpch." + hiveTableName);
assertUpdate("DROP TABLE iceberg.tpch." + icebergTableName);
Expand Down
Loading