Decouple IAM security mapping from S3 filesystem and add Glue support #26768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer
This PR is an updated version of #26287, as it can't be reopened because of the force-push (rebase).
Description
This PR decouples generic (not S3-related) security mapping code from S3 filesystem into a new library
trino-iam-aws, as well as adds security mapping support for Glue metastore.Additional context and related issues
Related issue: #26286
I'm open to any suggestions related to this implementation, especially when it comes to config parameters - I've been a bit uncomfortable with duplicating so much, but it makes more sense to me than mixing parameters from base class and subclass (like
iam.security-mapping.config-fileands3.security-mapping.kms-key-id-credential-name).This is my first contribution to Trino, while Java definitely not being my favourite language, so please get easy on me! 😉
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: