Require implementing shutdown method on a Connector #26718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
approved these changes
Sep 26, 2025
plugin/trino-jmx/src/main/java/io/trino/plugin/jmx/JmxConnector.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/unloadable-catalogs
branch
from
bb0e507 to
a12029c
Compare
This ensures that at least every Connector will call LifeCycleManager.stop() which is important because every Bootstrap creates one LifeCycleManager which registers itself with the shutdown hook creating a shutdown Thread.
wendigo
force-pushed
the
serafin/unloadable-catalogs
branch
from
a12029c to
3696248
Compare
|
@wendigo Could you update "Release notes" section in PR description? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that at least every Connector will call LifeCycleManager.stop()
which is important because every Bootstrap creates one LifeCycleManager
which registers itself with the shutdown hook creating a shutdown Thread.
Description
Additional context and related issues
Release note
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: