Fix failures for EXPLAIN and EXPLAIN ANALYZE on OPTIMIZE queries #26670

yangshangqing95 · 2025-09-19T02:54:46Z

Description

This PR fixes failures when running EXPLAIN and EXPLAIN ANALYZE on Iceberg OPTIMIZE statements:

Fixed server-side failure in EXPLAIN; EXPLAIN prints an error on the server side, which is only ignored because of the IGNORE_STATS_CALCULATOR_FAILURES session property. When this property is set to false, it can still cause the query to fail.

Exception example:

java.lang.IllegalArgumentException: Unexpected scanned files recording set
	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:141)
	at io.trino.plugin.iceberg.IcebergMetadata.getTableStatistics(IcebergMetadata.java:3546)
	at io.trino.plugin.base.classloader.ClassLoaderSafeConnectorMetadata.getTableStatistics(ClassLoaderSafeConnectorMetadata.java:356)
	at io.trino.tracing.TracingConnectorMetadata.getTableStatistics(TracingConnectorMetadata.java:333)
	at io.trino.metadata.MetadataManager.getTableStatistics(MetadataManager.java:492)
	at io.trino.tracing.TracingMetadata.getTableStatistics(TracingMetadata.java:318)
	at io.trino.cost.CachingTableStatsProvider.getTableStatisticsInternal(CachingTableStatsProvider.java:53)
	at java.base/java.util.Map.computeIfAbsent(Map.java:1067)
   .......

Fixed failure in EXPLAIN ANALYZE OPTIMIZE.
- Related issue: #26598

This change ensures both EXPLAIN and EXPLAIN ANALYZE OPTIMIZE queries complete without errors.

Additional context and related issues

Fixes #26598

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## Iceberg
* Fix failures when running EXPLAIN or EXPLAIN ANALYZE on `ALTER TABLE EXECUTE OPTIMIZE` queries. ({issue}`26598`)

cla-bot · 2025-09-19T02:54:49Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

raunaqmorarka · 2025-10-06T14:31:18Z

@cla-bot check

cla-bot · 2025-10-06T14:31:21Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-10-06T14:31:23Z

The cla-bot has been summoned, and re-checked this pull request!

plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java

cla-bot · 2025-10-06T22:53:06Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-10-06T22:54:34Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

yangshangqing95 · 2025-10-07T17:21:13Z

@cla-bot check

cla-bot · 2025-10-07T17:21:16Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-10-07T17:21:17Z

The cla-bot has been summoned, and re-checked this pull request!

chenjian2664 · 2025-10-12T02:42:32Z

@cla-bot check

cla-bot · 2025-10-12T02:42:36Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-10-12T02:42:36Z

The cla-bot has been summoned, and re-checked this pull request!

yangshangqing95 · 2025-10-17T23:44:36Z

@cla-bot check

cla-bot · 2025-10-17T23:44:41Z

The cla-bot has been summoned, and re-checked this pull request!

raunaqmorarka

minor comments around tests, lgtm otherwise

plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java

...trino-main/src/test/java/io/trino/sql/planner/sanity/TestTableExecuteStructureValidator.java

raunaqmorarka

Please rebase to latest master

plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java

yangshangqing95 · 2025-10-22T19:28:37Z

Please rebase to latest master
sure, rebased

1. Fixed server-side failure in EXPLAIN; when IGNORE_STATS_CALCULATOR_FAILURES is false, the query failed. 2. Fixed failure in EXPLAIN ANALYZE OPTIMIZE.

github-actions bot added the iceberg Iceberg connector label Sep 19, 2025

raunaqmorarka reviewed Oct 6, 2025

View reviewed changes

plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java Show resolved Hide resolved

yangshangqing95 force-pushed the fix-explain-optimize branch from f5a56ac to 29c5d35 Compare October 6, 2025 22:53

yangshangqing95 force-pushed the fix-explain-optimize branch from 29c5d35 to ab31deb Compare October 6, 2025 22:54

cla-bot bot added the cla-signed label Oct 17, 2025

raunaqmorarka reviewed Oct 22, 2025

View reviewed changes

plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java Outdated Show resolved Hide resolved

...trino-main/src/test/java/io/trino/sql/planner/sanity/TestTableExecuteStructureValidator.java Outdated Show resolved Hide resolved

raunaqmorarka requested a review from losipiuk October 22, 2025 11:28

raunaqmorarka changed the title ~~Fix failures for EXPLAIN and EXPLAIN ANALYZE on Iceberg OPTIMIZE queries~~ Fix failures for EXPLAIN and EXPLAIN ANALYZE on OPTIMIZE queries Oct 22, 2025

raunaqmorarka requested a review from ebyhr October 22, 2025 11:28

yangshangqing95 force-pushed the fix-explain-optimize branch from ab31deb to 45a21a4 Compare October 22, 2025 15:03

raunaqmorarka reviewed Oct 22, 2025

View reviewed changes

plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java Outdated Show resolved Hide resolved

yangshangqing95 force-pushed the fix-explain-optimize branch 2 times, most recently from f398d1b to 6b16235 Compare October 22, 2025 19:26

Fix failures for EXPLAIN and EXPLAIN ANALYZE on Iceberg OPTIMIZE queries

cea34a1

1. Fixed server-side failure in EXPLAIN; when IGNORE_STATS_CALCULATOR_FAILURES is false, the query failed. 2. Fixed failure in EXPLAIN ANALYZE OPTIMIZE.

raunaqmorarka force-pushed the fix-explain-optimize branch from 6b16235 to cea34a1 Compare October 23, 2025 06:04

raunaqmorarka approved these changes Oct 23, 2025

View reviewed changes

raunaqmorarka merged commit 550371a into trinodb:master Oct 23, 2025
192 of 195 checks passed

github-actions bot added this to the 478 milestone Oct 23, 2025

ebyhr mentioned this pull request Oct 25, 2025

Add Trino 478 release note #26726

Closed

Fix failures for EXPLAIN and EXPLAIN ANALYZE on OPTIMIZE queries #26670

Fix failures for EXPLAIN and EXPLAIN ANALYZE on OPTIMIZE queries #26670

Uh oh!

Conversation

yangshangqing95 commented Sep 19, 2025 • edited by raunaqmorarka Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Additional context and related issues

Release notes

Uh oh!

cla-bot bot commented Sep 19, 2025

Uh oh!

raunaqmorarka commented Oct 6, 2025

Uh oh!

cla-bot bot commented Oct 6, 2025

Uh oh!

cla-bot bot commented Oct 6, 2025

Uh oh!

Uh oh!

cla-bot bot commented Oct 6, 2025

Uh oh!

cla-bot bot commented Oct 6, 2025

Uh oh!

yangshangqing95 commented Oct 7, 2025

Uh oh!

cla-bot bot commented Oct 7, 2025

Uh oh!

cla-bot bot commented Oct 7, 2025

Uh oh!

chenjian2664 commented Oct 12, 2025

Uh oh!

cla-bot bot commented Oct 12, 2025

Uh oh!

cla-bot bot commented Oct 12, 2025

Uh oh!

yangshangqing95 commented Oct 17, 2025

Uh oh!

cla-bot bot commented Oct 17, 2025

Uh oh!

raunaqmorarka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

raunaqmorarka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yangshangqing95 commented Oct 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

yangshangqing95 commented Sep 19, 2025 •

edited by raunaqmorarka

Loading