Pre-populate file length and modifiedTime in LinePageSourceFactory #26615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
requested review from
Copilot,
dain,
electrum,
pettyjamesm and
wendigo
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the LinePageSourceFactory to pre-populate file metadata (length and modified time) when creating TrinoInputFile objects. This optimization allows S3InputStream to avoid aborting connections and enables the filesystem cache to avoid extra filesystem operations by providing metadata upfront rather than fetching it lazily.
- Pre-populates TrinoInputFile with file length and modification time
- Updates method signature to accept fileModifiedTime parameter
- Passes estimatedFileSize and fileModifiedTime to the TrinoInputFile constructor
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
wendigo
approved these changes
Sep 11, 2025
pettyjamesm
approved these changes
Sep 11, 2025
Contributor
|
Failure is related |
Allows S3InputStream#closeStream to avoid aborting connections Allows filsystem cache to avoid extra FS operations
raunaqmorarka
force-pushed
the
line-length
branch
from
2a5f9bb to
f82e822
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ive-formats/src/main/java/io/trino/hive/formats/line/sequence/SequenceFileReaderFactory.java
Show resolved
Hide resolved
electrum
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows S3InputStream#closeStream to avoid aborting connections
Allows filsystem cache to avoid extra FS operations
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: