Change the visibility of shared variables in TimeSharingTaskHandle from protected to private #26584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
approved these changes
Sep 8, 2025
SongChujun
changed the title
Member
|
Could you shorten the commit title? https://trino.io/development/process#pull-request-and-commit-guidelines-
|
SongChujun
force-pushed
the
time_sharing_task_handle_sync_fix
branch
from
a2bc4dc to
1a8222b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Keeping the shared variable here to have protected access makes it possible that its values get mutated outside of this class without proper synchronization
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.