Minor cleanups in OpenLineage plugin #26528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
changed the title
ebyhr
approved these changes
Sep 2, 2025
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
We could run "Reformat Code" for the entire trino-openlineage module. There are additional places we can fix.
Praveen2112
force-pushed
the
praveen/open_lineage_pr/fix
branch
from
358057e to
c8fa943
Compare
Member
Author
|
@ebyhr Thanks for pointers - Have updated them as well. |
ebyhr
approved these changes
Sep 2, 2025
| .getFacets() | ||
| .getAdditionalProperties() | ||
| .get("trino_metadata") | ||
| .getAdditionalProperties(); |
Member
There was a problem hiding this comment.
I prefer the following style reducing nested indentations, but feel free to ignore this comment:
Map<String, Object> trinoQueryContext = result
.getRun()
.getFacets()
.getAdditionalProperties()
.get("trino_query_context")
.getAdditionalProperties();
chenjian2664
approved these changes
Sep 2, 2025
dolfinus
approved these changes
Sep 2, 2025
wendigo
approved these changes
Sep 2, 2025
Praveen2112
force-pushed
the
praveen/open_lineage_pr/fix
branch
from
c8fa943 to
1dda7c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up PR for additional comments as a part of #25704
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: