Skip to content

Conversation

@raunaqmorarka
Copy link
Member

@raunaqmorarka raunaqmorarka commented Sep 1, 2025

Description

rawInputDataSize is redundant with internalNetworkInputDataSize + physicalInputDataSize
rawInputPositions is redundant with processedInputPositions

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## General
* Add `internal_network_input_bytes` column to `system.runtime.tasks` table. ({issue}`26524`)
* Remove `raw_input_bytes` and `raw_input_rows` columns from `system.runtime.tasks` table. ({issue}`26524`)
* Remove `totalBytes` and `totalRows` from `io.trino.spi.eventlistener.QueryStatistics`. ({issue}`26524`)

@cla-bot cla-bot bot added the cla-signed label Sep 1, 2025
@github-actions github-actions bot added the ui Web UI label Sep 1, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the redundant tracking of rawInputDataSize and rawInputPositions from the Trino codebase. The key insight is that rawInputDataSize can be calculated as internalNetworkInputDataSize + physicalInputDataSize, and rawInputPositions is redundant with processedInputPositions.

Key changes include:

  • Removal of raw input tracking fields from statistics classes
  • Update of APIs to use equivalent existing metrics
  • Modification of tests to reflect the new data structure

Reviewed Changes

Copilot reviewed 51 out of 51 changed files in this pull request and generated no comments.

Show a summary per file
File Description
core/trino-spi/src/main/java/io/trino/spi/eventlistener/QueryStatistics.java Removes totalBytes and totalRows fields from QueryStatistics API
core/trino-main/src/main/java/io/trino/execution/QueryStats.java Removes rawInputDataSize and rawInputPositions fields from QueryStats
core/trino-main/src/main/java/io/trino/operator/*.java Updates operator statistics classes to remove raw input tracking
plugin/trino-mysql-event-listener/src/main/java/io/trino/plugin/eventlistener/mysql/MysqlEventListener.java Updates to use calculated values instead of removed fields
testing/trino-tests/src/test/java/io/trino/execution/TestEventListenerWithSplits.java Updates test expectations to use processedInputRows instead of totalRows

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

rawInputDataSize is redundant with internalNetworkInputDataSize + physicalInputDataSize
rawInputPositions is redundant with processedInputPositions
@raunaqmorarka raunaqmorarka merged commit 9ca4c3c into trinodb:master Sep 2, 2025
95 checks passed
@raunaqmorarka raunaqmorarka deleted the clean-raw branch September 2, 2025 17:08
@github-actions github-actions bot added this to the 477 milestone Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants