Improve readability of ReadRowsHelper debug log #26518

joyhaldar · 2025-08-30T11:23:17Z

Description

The existing log statement in ReadRowsHelper logs the full ReadRowsResponse object, which can contain large and unreadable serialized Arrow batches. This clutters the logs and makes debugging difficult.

Example:

2025-03-25T15:37:20.578+0900	DEBUG	bigquery-bigquery-5	io.trino.plugin.bigquery.ReadRowsHelper	ReadRowsResponse from BigQuery: stats {
  progress {
    at_response_end: 0.001469222130253911
  }
}
arrow_record_batch {
  serialized_record_batch: "\377\377\377\377\360\a\000\000\024\000\000\000\000\000\000\000\f\000\030\000\006\000\005\000\b\000\f\000\f\000\000\000\000\003\004\000\034\000\000\0000)\001\000\000\000\000\000\000\000\000\000\f\000\036\000\020\000\004\000\b\000\f\000\f\000\000\000\320\005\000\000$\000\000\000\030\000\000\000\300\003\000\000\000\000\000\000\000\000\000\000\000\000\006\000\b\000\a\000\006\000\000\000\000\000\000\001Z\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\310\t\000\000\000\000\000\000\310\t\000\000\000\000\000\000\036\000\000\000\000\000\000\000\350\t\000\000\000\000\000\000\000\000\000\000\000\000\000\000\350\t\000\000\000\000\000\000\310\t\000\000\000\000\000\000\260\023\000\000\000\000\000\000\036\000\000\000\000\000\000\000\320\023\000\000\000\000\000\000\000\000\000\000\000\000\000\000\320\023\000\000\000\000\000\000\310\t\000\000\000\000\000\000\230\035\000\000\000\000\000\000\036\000\000\000\000\000\000\000\270\035\000\000\000\000\000\000\000\000\000\000\000\000\000\000\270\035\000\000\000\000\000\000\310\t\000\000\000\000\000\000\200\'\000\000\000\000\000\000\036\000\000\000\000\000\000\000\240\'\000\000\000\000\000\000\000\000\000\000\000\000\000\000\240\'\000\000\000\000\000\000\310\t\000\000\000\000\000\000h1\000\000\000\000\000\000\036\000\000\000\000\000\000\000\2101\000\000\000\000\000\000\000\000\000\000\000\000\000\000\2101\000\000\000\000\000\000\310\t\000\000\000\000\000\000P;\000\000\000\000\000\000\036\000\000\000\000\000\000\000p;\000\000\000\000\000\000\000\000\000\000\000\000\000\000p;\000\000\000\000\000\000\310\t\000\000\000\000\000\0008E\000\000\000\000\000\000\036\000\000\000\000\000\000\000XE\000\000\000\000\000\000\000\000\000\000\000\000\000\000XE\000\000\000\000\000\000\310\t\000\000\000\000\000\000 O\000\000\000\000\000\000\036\000\000\000\000\000\000\000@O\000\000\000\000\000\000\000\000\000\000\000\000\000\000@O\000\000\000\000\000\000\310\t\000\000\000\000\000\000\bY\000\000\000\000\000\000\036\000\000\000\000\000\000\000(Y\000\000\000\000\000\000\000\000\000\000\000\000\000\000
...
...
...

This change updates the log to:

log.debug("ReadRowsResponse from BigQuery stream: %s at offset: %s", helper.streamName, nextOffset);

This preserves useful logging for monitoring progress while avoiding unnecessary output of serialized record data.

Additional context and related issues

Fixes #25409 by replacing a verbose debug log that printed the entire ReadRowsResponse with a concise message logging only the stream name and offset.

Screenshot (local run)

Trino running locally and logging expected debug message:

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

cla-bot · 2025-08-30T11:23:19Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Joy Haldar.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

joyhaldar · 2025-08-30T11:37:28Z

I have emailed a signed copy of the Trino Foundation Individual CLA.

plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/ReadRowsHelper.java

cla-bot · 2025-08-31T06:21:12Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Joy Haldar.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2025-08-31T06:29:18Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Joy Haldar.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

joyhaldar · 2025-09-16T08:45:15Z

Hello @raunaqmorarka , @ebyhr, any chance you might have information on my signed copy of the Trino Foundation Individual CLA being on record?

raunaqmorarka · 2025-09-16T08:51:58Z

@cla-bot check

cla-bot · 2025-09-16T08:52:01Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Joy Haldar.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2025-09-16T08:52:02Z

The cla-bot has been summoned, and re-checked this pull request!

cla-bot · 2025-09-16T09:12:39Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Joy Haldar.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

joyhaldar · 2025-09-17T17:16:14Z

I've just received an email stating that my signed CLA has been received.

martint · 2025-09-17T17:27:07Z

@cla-bot check

cla-bot · 2025-09-17T17:27:09Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Joy Haldar.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2025-09-17T17:27:10Z

The cla-bot has been summoned, and re-checked this pull request!

raunaqmorarka · 2025-09-17T19:29:16Z

@cla-bot check

cla-bot · 2025-09-17T19:29:19Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Joy Haldar.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2025-09-17T19:29:20Z

The cla-bot has been summoned, and re-checked this pull request!

ebyhr · 2025-09-17T20:46:33Z

@cla-bot check

cla-bot · 2025-09-17T20:46:37Z

The cla-bot has been summoned, and re-checked this pull request!

github-actions bot added the bigquery BigQuery connector label Aug 30, 2025

raunaqmorarka requested a review from ebyhr August 30, 2025 16:53

ebyhr reviewed Aug 31, 2025

View reviewed changes

plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/ReadRowsHelper.java Outdated Show resolved Hide resolved

ebyhr force-pushed the log-readrowsresponse-offset-only branch from 86a91de to 7f0be6d Compare August 31, 2025 06:29

ebyhr approved these changes Aug 31, 2025

View reviewed changes

joyhaldar force-pushed the log-readrowsresponse-offset-only branch from 7f0be6d to 765a6c1 Compare September 16, 2025 09:12

chenjian2664 approved these changes Sep 17, 2025

View reviewed changes

Improve readability of ReadRowsHelper debug log

3bd9fa3

ebyhr force-pushed the log-readrowsresponse-offset-only branch from 765a6c1 to 3bd9fa3 Compare September 17, 2025 20:46

cla-bot bot added the cla-signed label Sep 17, 2025

ebyhr merged commit 39da6f4 into trinodb:master Sep 17, 2025
3 of 12 checks passed

github-actions bot added this to the 477 milestone Sep 17, 2025

ebyhr mentioned this pull request Sep 19, 2025

Add Trino 477 release notes #26350

Merged

joyhaldar deleted the log-readrowsresponse-offset-only branch September 20, 2025 08:22

Improve readability of ReadRowsHelper debug log #26518

Improve readability of ReadRowsHelper debug log #26518

Uh oh!

Conversation

joyhaldar commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Additional context and related issues

Screenshot (local run)

Release notes

Uh oh!

cla-bot bot commented Aug 30, 2025

Uh oh!

joyhaldar commented Aug 30, 2025

Uh oh!

Uh oh!

cla-bot bot commented Aug 31, 2025

Uh oh!

cla-bot bot commented Aug 31, 2025

Uh oh!

joyhaldar commented Sep 16, 2025

Uh oh!

raunaqmorarka commented Sep 16, 2025

Uh oh!

cla-bot bot commented Sep 16, 2025

Uh oh!

cla-bot bot commented Sep 16, 2025

Uh oh!

cla-bot bot commented Sep 16, 2025

Uh oh!

joyhaldar commented Sep 17, 2025

Uh oh!

martint commented Sep 17, 2025

Uh oh!

cla-bot bot commented Sep 17, 2025

Uh oh!

cla-bot bot commented Sep 17, 2025

Uh oh!

raunaqmorarka commented Sep 17, 2025

Uh oh!

cla-bot bot commented Sep 17, 2025

Uh oh!

cla-bot bot commented Sep 17, 2025

Uh oh!

ebyhr commented Sep 17, 2025

Uh oh!

cla-bot bot commented Sep 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

joyhaldar commented Aug 30, 2025 •

edited

Loading