Skip to content

Conversation

@electrum
Copy link
Member

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@electrum electrum requested review from kasiafi and martint August 27, 2025 00:21
@cla-bot cla-bot bot added the cla-signed label Aug 27, 2025
@electrum electrum requested a review from Copilot August 27, 2025 00:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the validation logic for the Case IR node by consolidating type validation checks. Instead of separately validating that all when clauses have the same result type and that the default value matches the first when clause's type, it now validates that all when clause results match the default value's type.

  • Consolidated type validation logic by comparing all when clause results against the default value type
  • Added argument validation to ensure when clauses are not empty
  • Removed redundant validation loops

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@wendigo wendigo merged commit 9ec15b3 into trinodb:master Aug 27, 2025
160 of 162 checks passed
@github-actions github-actions bot added this to the 477 milestone Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants