Return user visible error when catalog is misconfigured #26482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
force-pushed
the
origin/master/001_error-message
branch
from
763bed4 to
a952b7a
Compare
wendigo
approved these changes
Aug 27, 2025
homar
approved these changes
Aug 27, 2025
When Driver::connect returns null, most likely it catalog is misconfigured and error message from the checkState was propagated to the user making looking obscure. Before: Query 20250825_145634_00011_9263i failed: Error listing schemas for catalog postgresql2: com.google.common.util.concurrent.UncheckedExecutionException: java.lang.IllegalStateException: Driver returned null connection, make sure the connection URL 'jdbc:psql://test' is valid for the driver org.postgresql.Driver@63a777ba After: Query 20250825_150832_00003_52kd7 failed: Error listing schemas for catalog postgresql: Driver returned null connection, make sure the connection URL 'jdbc:jdbc:postgresql://localhost:5432/tpch' and credentials are valid
kokosing
force-pushed
the
origin/master/001_error-message
branch
from
a952b7a to
b0e485c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Driver::connect returns null, most likely it catalog is
misconfigured and error message from the checkState was propagated to
the user making looking obscure.
Before:
Query 20250825_145634_00011_9263i failed: Error listing schemas for
catalog postgresql2:
com.google.common.util.concurrent.UncheckedExecutionException:
java.lang.IllegalStateException: Driver returned null connection, make
sure the connection URL 'jdbc:psql://test' is valid for the driver
org.postgresql.Driver@63a777ba
After:
Query 20250825_150832_00003_52kd7 failed: Error listing schemas for
catalog postgresql: Driver returned null connection, make sure the
connection URL 'jdbc:jdbc:postgresql://localhost:5432/tpch' and
credentials are valid
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: