Reuse IdentityCacheMapping for BigQuery #26478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
hive
Praveen2112
reviewed
Aug 26, 2025
| * limitations under the License. | ||
| */ | ||
| package io.trino.plugin.jdbc; | ||
| package io.trino.plugin.base.authentication.cache; |
Member
There was a problem hiding this comment.
Why do we need this under authentication ?
Member
There was a problem hiding this comment.
Identity is part of authentication layer
Member
There was a problem hiding this comment.
Yes - But this cache mapping is more of a derivative based on Identity right ?
Contributor
Author
There was a problem hiding this comment.
@Praveen2112 repackaged to cache.identity and dropped unrelated kerberos repackage. PTAL.
kokosing
approved these changes
Aug 26, 2025
| * limitations under the License. | ||
| */ | ||
| package io.trino.plugin.jdbc; | ||
| package io.trino.plugin.base.authentication.cache; |
Member
There was a problem hiding this comment.
Identity is part of authentication layer
chenjian2664
approved these changes
Aug 27, 2025
Contributor
chenjian2664
left a comment
chenjian2664
left a comment
There was a problem hiding this comment.
the description seems broken
ssheikin
force-pushed
the
ssheikin/72/trino/ms
branch
from
cb37cf1 to
38af310
Compare
ssheikin
changed the title
Praveen2112
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: