Perform disjoint/contains operation on Polygon instead of Envelope #26459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would fix issue related to inaccuracies when converting from Geometry to BingTile. Benchmark also shows an improvement in average time per operation Before: Benchmark Mode Cnt Score Error Units BenchmarkGeometryToBingTiles.envelopeToBingTiles avgt 10 0.007 ± 0.001 ms/op BenchmarkGeometryToBingTiles.geometryToBingTiles avgt 10 172.830 ± 5.088 ms/op After: Benchmark Mode Cnt Score Error Units BenchmarkGeometryToBingTiles.envelopeToBingTiles avgt 10 0.007 ± 0.001 ms/op BenchmarkGeometryToBingTiles.geometryToBingTiles avgt 10 104.172 ± 0.749 ms/op
wendigo
approved these changes
Aug 21, 2025
martint
reviewed
Aug 21, 2025
raunaqmorarka
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This would fix issue related to inaccuracies when converting from Geometry to BingTile.
Benchmark also shows an improvement in average time per operation
Before:
Benchmark Mode Cnt Score Error Units
BenchmarkGeometryToBingTiles.envelopeToBingTiles avgt 10 0.007 ± 0.001 ms/op
BenchmarkGeometryToBingTiles.geometryToBingTiles avgt 10 172.830 ± 5.088 ms/op
After:
Benchmark Mode Cnt Score Error Units
BenchmarkGeometryToBingTiles.envelopeToBingTiles avgt 10 0.007 ± 0.001 ms/op
BenchmarkGeometryToBingTiles.geometryToBingTiles avgt 10 104.172 ± 0.749 ms/op
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: