Overload to_geojson_geometry to support geometries #26451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
reviewed
Aug 22, 2025
| { | ||
| return new GeoJsonWriter().write(geometry); | ||
| GeoJsonWriter geoJsonWriter = new GeoJsonWriter(); | ||
| geoJsonWriter.setEncodeCRS(false); |
Member
There was a problem hiding this comment.
Move this to a separate commit to keep logically independent changes separate.
| @Description("Returns GeoJSON string based on the input spherical geography") | ||
| @SqlType(VARCHAR) | ||
| public static Slice toGeoJsonGeometry(@SqlType(StandardTypes.SPHERICAL_GEOGRAPHY) Slice input) | ||
| public static Slice toGeoJsonGeometryFromGeography(@SqlType(StandardTypes.SPHERICAL_GEOGRAPHY) Slice input) |
Member
There was a problem hiding this comment.
Rename the method to geographyToGeoJson
Contributor
Author
There was a problem hiding this comment.
That's much better. Thank you.
Done
| @ScalarFunction("to_geojson_geometry") | ||
| @Description("Returns GeoJSON string based on the input geometry") | ||
| @SqlType(VARCHAR) | ||
| public static Slice toGeoJsonGeometryFromGeometry(@SqlType(StandardTypes.GEOMETRY) Slice input) |
Member
There was a problem hiding this comment.
Similarly, rename this one to geometryToGeoJson
| assertGeometryToAndFromJson("LINESTRING (0 0, 1 1, 1 0, 0 1)"); | ||
| } | ||
|
|
||
| private void assertGeometryToAndFromJson(String wkt) |
Member
There was a problem hiding this comment.
Rename the other method (assertGeoToAndFromJson) to assertGeographyToAndFromJson to avoid confusion with this one.
umartin
force-pushed
the
to_geojson_geometry
branch
from
ad9e3f2 to
55f5716
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow converting geometries, and not only spherical geographies, to GeoJSON
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: