Skip to content

Enforce restriction on dropping hidden metadata columns in Iceberg #26417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

Enforce restriction on dropping hidden metadata columns in Iceberg #26417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,6 +1007,7 @@ public ColumnMetadata getColumnMetadata(ConnectorSession session, ConnectorTable
.setType(column.getType())
.setNullable(column.isNullable())
.setComment(column.getComment())
.setHidden(isMetadataColumnId(column.getId()))
.build();
}

Expand Down
10 changes: 10 additions & 0 deletions plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1815,6 +1815,16 @@ public void testDropPartitionColumn()
assertUpdate("DROP TABLE " + tableName);
}

@Test
void testDropHiddenMetadataColumn()
{
try (TestTable table = newTrinoTable("test_drop_metadata_column_", "(id int, col int)")) {
assertQueryFails("ALTER TABLE " + table.getName() + " DROP COLUMN \"$partition\"", "line 1:1: Cannot drop hidden column");
assertQueryFails("ALTER TABLE " + table.getName() + " DROP COLUMN \"$path\"", "line 1:1: Cannot drop hidden column");
assertQueryFails("ALTER TABLE " + table.getName() + " DROP COLUMN \"$file_modified_time\"", "line 1:1: Cannot drop hidden column");
}
}

@Test
public void testDropColumnUsedInOlderPartitionSpecs()
{
Expand Down