Don't set max_commit_retry Iceberg table property by default #26359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/iceberg-max-retry
branch
from
5961912 to
7eae888
Compare
chenjian2664
approved these changes
Aug 7, 2025
wendigo
approved these changes
Aug 8, 2025
raunaqmorarka
approved these changes
Aug 8, 2025
| - Number of times to retry a commit before failing. Defaults to the value of | ||
| the `iceberg.max-commit-retry` catalog configuration property, which | ||
| defaults to `4`. | ||
| the `iceberg.max-commit-retry` catalog configuration property. |
Member
There was a problem hiding this comment.
Document should still mention the iceberg default
Member
Author
There was a problem hiding this comment.
I removed it because I was worried about the upstream change. I will revert anyway since the value looks stable.
ebyhr
force-pushed
the
ebi/iceberg-max-retry
branch
from
7eae888 to
4c6c298
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting the table property to Iceberg's default value is redundant.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.