Check if HNS is enabled for Azure storage account using Get Account Info #26354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/test-with-secrets sha=022f7f44393a4076e41d73116d82aa996e36ed52 |
Member
Author
|
If it passes the azure fs cloud tests then we'll know it's legit |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/16792688171 |
Member
Author
|
It looks like that test with secrets workflow might've run for a different branch |
Contributor
|
Running tests here: #26378 |
wendigo
approved these changes
Aug 8, 2025
Contributor
|
Azure tests have passed, lgtm :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to this comment from an Azure engineer, the version 12.31.0 of the azure-storage-blob dependency now supports OAuth for the Get Account Info endpoint. This PR updates the check for HNS on a storage account to use the Get Account Info endpoint, rather than the "hack" introduced in #20897.
Additional context and related issues
#20897
Azure/azure-sdk-for-java#38912 (comment)
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: