Iceberg SystemTable re-org and utility method clean up #26340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Aug 5, 2025
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/util/SystemTableUtil.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/util/SystemTableUtil.java
Show resolved
Hide resolved
ebyhr
reviewed
Aug 5, 2025
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/util/SystemTableUtil.java
Outdated
Show resolved
Hide resolved
tbaeg
force-pushed
the
system-table-reorg
branch
from
89dac56 to
372990d
Compare
Contributor
|
Please rephrase the commit message title https://trino.io/development/process.html#pull-request-and-commit-guidelines- |
tbaeg
force-pushed
the
system-table-reorg
branch
from
372990d to
ab14c51
Compare
Member
Author
Done. |
ebyhr
reviewed
Aug 5, 2025
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/util/SystemTableUtil.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/util/SystemTableUtil.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/util/SystemTableUtil.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
Aug 5, 2025
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/system/EntriesTable.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/system/FilesTable.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/system/PartitionsTable.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/system/PartitionsTable.java
Outdated
Show resolved
Hide resolved
...n/trino-iceberg/src/main/java/io/trino/plugin/iceberg/system/files/FilesTablePageSource.java
Outdated
Show resolved
Hide resolved
...n/trino-iceberg/src/main/java/io/trino/plugin/iceberg/system/files/FilesTablePageSource.java
Outdated
Show resolved
Hide resolved
...n/trino-iceberg/src/main/java/io/trino/plugin/iceberg/system/files/FilesTablePageSource.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/util/SystemTableUtil.java
Show resolved
Hide resolved
tbaeg
force-pushed
the
system-table-reorg
branch
2 times, most recently
from
ad188f8 to
7725735
Compare
Member
Author
|
I ended up cleaning up some duplicate/similar methods as well. Specifically, |
tbaeg
force-pushed
the
system-table-reorg
branch
3 times, most recently
from
d7e14b4 to
67cf44d
Compare
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/system/AllManifestsTable.java
Show resolved
Hide resolved
Member
|
Could you rebase on master and resolve conflicts? |
tbaeg
force-pushed
the
system-table-reorg
branch
from
67cf44d to
7eae9e0
Compare
raunaqmorarka
approved these changes
Aug 7, 2025
tbaeg
force-pushed
the
system-table-reorg
branch
from
7eae9e0 to
d7da2cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Co-locate
SystemTablerelated classes to system package and extract common static methods toSystemTableUtil.Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: