Skip to content

Fix loading DVs for partitions with special characters in Delta Lake #26302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2025
Merged

Fix loading DVs for partitions with special characters in Delta Lake #26302

merged 2 commits into from
Jul 30, 2025

Conversation

@chenjian2664
Copy link
Contributor

@chenjian2664 chenjian2664 commented Jul 30, 2025 •
edited by ebyhr
Loading

Description

Fix #26299

Release notes

## Delta Lake
* Fix incorrect results when the table uses deletion vectors and special characters are used in the partition path. ({issue}`26299`)

@cla-bot cla-bot bot added the cla-signed label Jul 30, 2025
@github-actions github-actions bot added the delta-lake Delta Lake connector label Jul 30, 2025
@chenjian2664 chenjian2664 requested a review from ebyhr July 30, 2025 01:27
@ebyhr
Copy link
Member

ebyhr commented Jul 30, 2025 •
edited
Loading

Please fix CI failures.

@chenjian2664
Copy link
Contributor Author

chenjian2664 commented Jul 30, 2025 

Error:  Could not acquire lock(s)
Error:  trino-server-core: Could not acquire lock(s)

It’s not related to the change?

@ebyhr
Copy link
Member

ebyhr commented Jul 30, 2025 

TestDeltaLakeBasic.testMergeOnClonedTable:2630->testMergeOnClonedTable:2678->AbstractTestQueryFramework.assertUpdate:421->AbstractTestQueryFramework.assertUpdate:426 » QueryFailed unexpected path: file:///tmp/catalog-dir3002203552218155233/clone_test_dir7d35duvmp2/clone_merge_deletion_vector_source/part-00000-9f6a8a5a-b5a9-4f09-b7c7-286735267e6b-c000.snappy.parquet

@chenjian2664
Copy link
Contributor Author

chenjian2664 commented Jul 30, 2025 •
edited
Loading

the cloned table might reference an absolute path file, let me check

@ebyhr ebyhr merged commit 659d95a into trinodb:master Jul 30, 2025
19 of 23 checks passed
@github-actions github-actions bot added this to the 477 milestone Jul 30, 2025
@ebyhr ebyhr mentioned this pull request Aug 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebyhr ebyhr ebyhr approved these changes

Assignees

No one assigned

Labels

cla-signed correctness delta-lake Delta Lake connector

Milestone

477

Development

Successfully merging this pull request may close these issues.

Repeated DELETE with deletion vectors duplicate rows in partitioned tables in Delta Lake with partitions that include whitespace

2 participants

@chenjian2664 @ebyhr