Skip to content

Conversation

@jinyangli34
Copy link
Contributor

@jinyangli34 jinyangli34 commented Jul 28, 2025

Description

Coordinator seems collecting query info & metrics in every query response only for QueryDataEncoding, which is already available in Session.
Trying to optimize and save coordinator resource.

Additional context and related issues

example jstack:

Query-20250722_170536_20208_gu27x-5473983 RUNNABLE #5473983
  at io.airlift.stats.TDigest.merge(TDigest.java:446)
  at io.airlift.stats.TDigest.mergeWith(TDigest.java:219)
  at io.trino.plugin.base.metrics.TDigestHistogram.mergeTo(TDigestHistogram.java:97)
  at io.trino.plugin.base.metrics.TDigestHistogram.mergeWith(TDigestHistogram.java:90)
  at io.trino.plugin.base.metrics.TDigestHistogram.mergeWith(TDigestHistogram.java:32)
  at io.trino.spi.metrics.Metrics$Accumulator.merge(Metrics.java:115)
  at io.trino.spi.metrics.Metrics$Accumulator.lambda$get$2(Metrics.java:108)
  at io.trino.spi.metrics.Metrics$Accumulator$$Lambda/0x00007f35d942e190.accept(:-1)
  at java.util.HashMap.forEach(HashMap.java:1430)
  at io.trino.spi.metrics.Metrics$Accumulator.get(Metrics.java:108)
  at io.trino.operator.OperatorStats.add(OperatorStats.java:601)
  at io.trino.operator.OperatorStats.add(OperatorStats.java:463)
  at io.trino.execution.StageStateMachine.combineTaskOperatorSummaries(StageStateMachine.java:730)
  at io.trino.execution.StageStateMachine.getStageInfo(StageStateMachine.java:597)
  at io.trino.execution.SqlStage.getStageInfo(SqlStage.java:225)
  at io.trino.execution.scheduler.StageManager$$Lambda/0x00007f35d93d1b48.apply(:-1)
  at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
  at com.google.common.collect.CollectSpliterators$1WithCharacteristics.lambda$forEachRemaining$1(CollectSpliterators.java:72)
  at com.google.common.collect.CollectSpliterators$1WithCharacteristics$$Lambda/0x00007f35d731ade0.accept(:-1)
  at java.util.stream.Streams$RangeIntSpliterator.forEachRemaining(Streams.java:104)
  at com.google.common.collect.CollectSpliterators$1WithCharacteristics.forEachRemaining(CollectSpliterators.java:72)
  at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:570)
  at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:560)
  at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
  at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:265)
  at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:727)
  at io.trino.execution.scheduler.StageManager.getStageInfo(StageManager.java:245)
  at io.trino.execution.scheduler.PipelinedQueryScheduler.getStageInfo(PipelinedQueryScheduler.java:461)
  at io.trino.execution.SqlQueryExecution.buildQueryInfo(SqlQueryExecution.java:746)
  at io.trino.execution.SqlQueryExecution.lambda$getQueryInfo$6(SqlQueryExecution.java:715)
  at io.trino.execution.SqlQueryExecution$$Lambda/0x00007f35d93d1920.get(:-1)
  at java.util.Optional.orElseGet(Optional.java:364)
  at io.trino.execution.SqlQueryExecution.getQueryInfo(SqlQueryExecution.java:715)
  at io.trino.execution.SqlQueryManager.getFullQueryInfo(SqlQueryManager.java:206)
  at io.trino.server.protocol.Query.getQueryInfo(Query.java:294)
  at io.trino.server.protocol.ExecutingStatementResource.lambda$asyncQueryResults$2(ExecutingStatementResource.java:238)

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jul 28, 2025
@wendigo wendigo merged commit 60d4926 into trinodb:master Jul 28, 2025
95 checks passed
@github-actions github-actions bot added this to the 477 milestone Jul 28, 2025
@ebyhr
Copy link
Member

ebyhr commented Aug 6, 2025

Could you update the release note entry?

@wendigo
Copy link
Contributor

wendigo commented Aug 6, 2025

@ebyhr sure, not needed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants