Remove unnecessary usage of SimplePagesHashStrategy #26273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
force-pushed
the
raunaq/simple-hash
branch
from
d62d4ca to
2639bac
Compare
wendigo
approved these changes
Jul 24, 2025
Member
|
I am fine with removing fallback to non-compiled version of pageshashstrategy but the commit message does not state that this commit does that. Please update. |
losipiuk
approved these changes
Jul 24, 2025
pettyjamesm
reviewed
Jul 24, 2025
raunaqmorarka
force-pushed
the
raunaq/simple-hash
branch
from
2639bac to
5125136
Compare
Compiled version of PagesHashStrategy results in same code as SimplePagesHashStrategy when joinChannels is empty
raunaqmorarka
force-pushed
the
raunaq/simple-hash
branch
from
5125136 to
4749378
Compare
raunaqmorarka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: