Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions core/trino-spi/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -185,16 +185,6 @@
<skip>${trino.check.skip-revapi}</skip>
<ignoreSuggestionsFormat>xml</ignoreSuggestionsFormat>
<analysisConfiguration>
<revapi.filter>
<elements>
<exclude>
<item>
<matcher>java</matcher>
<match>@io.trino.spi.Experimental(*) ^*;</match>
</item>
</exclude>
</elements>
</revapi.filter>
<revapi.differences>
<ignore>true</ignore>
<differences>
Expand Down Expand Up @@ -664,6 +654,14 @@
<old>method java.lang.String io.trino.spi.NodeManager::getEnvironment()</old>
<justification>Unused</justification>
</item>
<item>
<code>java.class.removed</code>
<annotationType>@interface io.trino.spi.Experimental</annotationType>
</item>
<item>
<code>java.annotation.removed</code>
<annotationType>io.trino.spi.Experimental</annotationType>
</item>
</differences>
</revapi.differences>
</analysisConfiguration>
Expand Down
44 changes: 0 additions & 44 deletions core/trino-spi/src/main/java/io/trino/spi/Experimental.java

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
*/
package io.trino.spi.block;

import io.trino.spi.Experimental;
import jakarta.annotation.Nullable;

import java.util.Optional;
Expand Down Expand Up @@ -231,13 +230,11 @@ boolean[] getRawValueIsNull()
return valueIsNull;
}

@Experimental(eta = "2023-12-31")
public int[] getRawValues()
{
return values;
}

@Experimental(eta = "2023-12-31")
public int getRawValuesOffset()
{
return arrayOffset;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
*/
package io.trino.spi.block;

import io.trino.spi.Experimental;

import java.util.Optional;

public non-sealed interface ValueBlock
Expand Down Expand Up @@ -49,6 +47,5 @@ default int getUnderlyingValuePosition(int position)
* Returns Optional.empty() when there are no NULLs in the Block.
* The returned ByteArrayBlock must not contain NULL values.
*/
@Experimental(eta = "2025-01-01")
Optional<ByteArrayBlock> getNulls();
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonValue;
import io.trino.spi.Experimental;
import io.trino.spi.catalog.CatalogName;

import java.util.Objects;
Expand All @@ -28,7 +27,6 @@
import static java.util.Locale.ROOT;
import static java.util.Objects.requireNonNull;

@Experimental(eta = "2023-02-01")
public final class CatalogHandle
{
private static final int INSTANCE_SIZE = instanceSize(CatalogHandle.class);
Expand Down Expand Up @@ -169,7 +167,6 @@ public boolean isInternal()
}
}

@Experimental(eta = "2023-02-01")
public static final class CatalogVersion
{
private static final int INSTANCE_SIZE = instanceSize(CatalogVersion.class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
*/
package io.trino.spi.connector;

import io.trino.spi.Experimental;
import io.trino.spi.function.FunctionProvider;
import io.trino.spi.function.table.ConnectorTableFunction;
import io.trino.spi.procedure.Procedure;
Expand Down Expand Up @@ -127,7 +126,6 @@ default Set<SystemTable> getSystemTables()
/**
* @return the set of procedures provided by this connector
*/
@Experimental(eta = "2022-10-31")
default Optional<FunctionProvider> getFunctionProvider()
{
return Optional.empty();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
package io.trino.spi.connector;

import io.airlift.slice.Slice;
import io.trino.spi.Experimental;
import io.trino.spi.RefreshType;
import io.trino.spi.TrinoException;
import io.trino.spi.expression.Call;
Expand Down Expand Up @@ -333,7 +332,6 @@ default Iterator<TableColumnsMetadata> streamTableColumns(ConnectorSession sessi
* (e.g. for all relations that would be returned by {@link #listTables(ConnectorSession, Optional)}).
* Redirected table names are included, but the comment for them is not.
*/
@Experimental(eta = "2024-01-01")
default Iterator<RelationColumnsMetadata> streamRelationColumns(
ConnectorSession session,
Optional<String> schemaName,
Expand Down Expand Up @@ -372,7 +370,6 @@ default Iterator<RelationColumnsMetadata> streamRelationColumns(
* (e.g. for all relations that would be returned by {@link #listTables(ConnectorSession, Optional)}).
* Redirected table names are included, but the comment for them is not.
*/
@Experimental(eta = "2024-01-01")
default Iterator<RelationCommentMetadata> streamRelationComments(ConnectorSession session, Optional<String> schemaName, UnaryOperator<Set<SchemaTableName>> relationFilter)
{
List<RelationCommentMetadata> materializedViews = getMaterializedViews(session, schemaName).entrySet().stream()
Expand Down Expand Up @@ -573,7 +570,7 @@ default void addColumn(ConnectorSession session, ConnectorTableHandle tableHandl
*
* @param parentPath path to a field within the column, without leaf field name.
*/
@Experimental(eta = "2023-06-01") // TODO add support for rows inside arrays and maps and for anonymous row fields
// TODO add support for rows inside arrays and maps and for anonymous row fields
default void addField(ConnectorSession session, ConnectorTableHandle tableHandle, List<String> parentPath, String fieldName, Type type, boolean ignoreExisting)
{
throw new TrinoException(NOT_SUPPORTED, "This connector does not support adding fields");
Expand All @@ -582,7 +579,6 @@ default void addField(ConnectorSession session, ConnectorTableHandle tableHandle
/**
* Set the specified column type
*/
@Experimental(eta = "2023-04-01")
default void setColumnType(ConnectorSession session, ConnectorTableHandle tableHandle, ColumnHandle column, Type type)
{
throw new TrinoException(NOT_SUPPORTED, "This connector does not support setting column types");
Expand All @@ -593,7 +589,6 @@ default void setColumnType(ConnectorSession session, ConnectorTableHandle tableH
*
* @param fieldPath path starting with column name. The path is always lower-cased. It cannot be an empty or a single element.
*/
@Experimental(eta = "2023-09-01")
default void setFieldType(ConnectorSession session, ConnectorTableHandle tableHandle, List<String> fieldPath, Type type)
{
throw new TrinoException(NOT_SUPPORTED, "This connector does not support setting field types");
Expand Down Expand Up @@ -629,7 +624,7 @@ default void renameColumn(ConnectorSession session, ConnectorTableHandle tableHa
* @param fieldPath path starting with column name.
* @param target the new field name. The field position and nested level shouldn't be changed.
*/
@Experimental(eta = "2023-09-01") // TODO add support for rows inside arrays and maps and for anonymous row fields
// TODO add support for rows inside arrays and maps and for anonymous row fields
default void renameField(ConnectorSession session, ConnectorTableHandle tableHandle, List<String> fieldPath, String target)
{
throw new TrinoException(NOT_SUPPORTED, "This connector does not support renaming fields");
Expand All @@ -648,7 +643,7 @@ default void dropColumn(ConnectorSession session, ConnectorTableHandle tableHand
*
* @param fieldPath path to a field within the column, without leading column name.
*/
@Experimental(eta = "2023-05-01") // TODO add support for rows inside arrays and maps and for anonymous row fields
// TODO add support for rows inside arrays and maps and for anonymous row fields
default void dropField(ConnectorSession session, ConnectorTableHandle tableHandle, ColumnHandle column, List<String> fieldPath)
{
throw new TrinoException(NOT_SUPPORTED, "This connector does not support dropping fields");
Expand All @@ -667,7 +662,6 @@ default Optional<ConnectorTableLayout> getNewTableLayout(ConnectorSession sessio
* If {@link Optional#empty()} is returned, the type will be used as is during table creation which may or may not be supported by the connector.
* The effective type shall be a type that is cast-compatible with the input type.
*/
@Experimental(eta = "2024-01-31")
default Optional<Type> getSupportedType(ConnectorSession session, Map<String, Object> tableProperties, Type type)
{
return Optional.empty();
Expand Down Expand Up @@ -975,7 +969,6 @@ default boolean isView(ConnectorSession session, SchemaTableName viewName)
/**
* Gets the view properties for the specified view.
*/
@Experimental(eta = "2024-06-01")
default Map<String, Object> getViewProperties(ConnectorSession session, SchemaTableName viewName)
{
return Map.of();
Expand Down Expand Up @@ -1132,7 +1125,6 @@ default void dropLanguageFunction(ConnectorSession session, SchemaFunctionName n
/**
* Creates the specified branch.
*/
@Experimental(eta = "2025-12-31")
default void createBranch(ConnectorSession session, ConnectorTableHandle tableHandle, String branch, Map<String, Object> properties)
{
throw new TrinoException(NOT_SUPPORTED, "This connector does not support creating branches");
Expand All @@ -1141,7 +1133,6 @@ default void createBranch(ConnectorSession session, ConnectorTableHandle tableHa
/**
* Drops the specified branch.
*/
@Experimental(eta = "2025-12-31")
default void dropBranch(ConnectorSession session, ConnectorTableHandle tableHandle, String branch)
{
throw new TrinoException(NOT_SUPPORTED, "This connector does not support dropping branches");
Expand All @@ -1150,7 +1141,6 @@ default void dropBranch(ConnectorSession session, ConnectorTableHandle tableHand
/**
* Fast-forwards the specified branch.
*/
@Experimental(eta = "2025-12-31")
default void fastForwardBranch(ConnectorSession session, ConnectorTableHandle tableHandle, String sourceBranch, String targetBranch)
{
throw new TrinoException(NOT_SUPPORTED, "This connector does not support fast-forwarding branches");
Expand All @@ -1159,7 +1149,6 @@ default void fastForwardBranch(ConnectorSession session, ConnectorTableHandle ta
/**
* Get all branches.
*/
@Experimental(eta = "2025-12-31")
default Collection<String> listBranches(ConnectorSession session, SchemaTableName tableName)
{
return List.of();
Expand All @@ -1168,7 +1157,6 @@ default Collection<String> listBranches(ConnectorSession session, SchemaTableNam
/**
* Does the specified branch exist.
*/
@Experimental(eta = "2025-12-31")
default boolean branchExists(ConnectorSession session, SchemaTableName tableName, String branch)
{
return listBranches(session, tableName).contains(branch);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
*/
package io.trino.spi.connector;

import io.trino.spi.Experimental;
import io.trino.spi.function.table.ConnectorTableFunctionHandle;

public interface ConnectorSplitManager
Expand All @@ -28,7 +27,6 @@ default ConnectorSplitSource getSplits(
throw new UnsupportedOperationException();
}

@Experimental(eta = "2023-07-31")
default ConnectorSplitSource getSplits(
ConnectorTransactionHandle transaction,
ConnectorSession session,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
*/
package io.trino.spi.connector;

import io.trino.spi.Experimental;

import java.util.Collections;
import java.util.LinkedHashMap;
import java.util.List;
Expand Down Expand Up @@ -48,7 +46,6 @@ public ConnectorTableMetadata(SchemaTableName table, List<ColumnMetadata> column
this(table, columns, properties, comment, List.of());
}

@Experimental(eta = "2023-03-31")
public ConnectorTableMetadata(SchemaTableName table, List<ColumnMetadata> columns, Map<String, Object> properties, Optional<String> comment, List<String> checkConstraints)
{
requireNonNull(table, "table is null");
Expand Down Expand Up @@ -90,7 +87,6 @@ public Optional<String> getComment()
*
* @return List of string representation of a Trino SQL scalar expression that can refer to table columns by name and produces a result coercible to boolean
*/
@Experimental(eta = "2023-03-31")
public List<String> getCheckConstraints()
{
return checkConstraints;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
*/
package io.trino.spi.connector;

import io.trino.spi.Experimental;

import java.util.List;
import java.util.StringJoiner;

Expand All @@ -31,7 +29,6 @@ public ConnectorTableSchema(SchemaTableName table, List<ColumnSchema> columns)
this(table, columns, List.of());
}

@Experimental(eta = "2023-03-31")
public ConnectorTableSchema(SchemaTableName table, List<ColumnSchema> columns, List<String> checkConstraints)
{
requireNonNull(table, "table is null");
Expand Down Expand Up @@ -60,7 +57,6 @@ public List<ColumnSchema> getColumns()
*
* @return List of string representation of a Trino SQL scalar expression that can refer to table columns by name and produces a result coercible to boolean
*/
@Experimental(eta = "2023-03-31")
public List<String> getCheckConstraints()
{
return checkConstraints;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,13 @@
*/
package io.trino.spi.connector;

import io.trino.spi.Experimental;

import java.util.List;
import java.util.Optional;
import java.util.stream.Stream;

import static io.trino.spi.connector.Preconditions.checkArgument;
import static java.util.Objects.requireNonNull;

@Experimental(eta = "2024-01-01")
public record RelationColumnsMetadata(
SchemaTableName name,
Optional<List<ConnectorMaterializedViewDefinition.Column>> materializedViewColumns,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,11 @@
*/
package io.trino.spi.connector;

import io.trino.spi.Experimental;

import java.util.Optional;

import static io.trino.spi.connector.Preconditions.checkArgument;
import static java.util.Objects.requireNonNull;

@Experimental(eta = "2024-01-01")
public record RelationCommentMetadata(
SchemaTableName name,
boolean tableRedirected,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,11 @@
package io.trino.spi.exchange;

import com.google.errorprone.annotations.ThreadSafe;
import io.trino.spi.Experimental;

import java.io.Closeable;
import java.util.concurrent.CompletableFuture;

@ThreadSafe
@Experimental(eta = "2024-03-01")
public interface Exchange
extends Closeable
{
Expand Down
Loading
Loading