Skip to content

Fix NPE due to NULL default column values #26171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

Fix NPE due to NULL default column values #26171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/trino-main/src/main/java/io/trino/sql/analyzer/ExpressionAnalyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3934,6 +3934,9 @@ private static void checkDefaultColumnValue(Session session, PlannerContext plan
if (type instanceof BooleanType) {
checkArgument(value instanceof Boolean, "Value must be true or false '%s'".formatted(value));
}
if (value == null) {
return;
}
if (type instanceof CharType charType) {
int targetLength = charType.getLength();
Slice slice = (Slice) value;
Expand Down
27 changes: 21 additions & 6 deletions core/trino-main/src/test/java/io/trino/util/TestColumnDefaultOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,6 @@ public TestColumnDefaultOptions()
plannerContext = plannerContextBuilder().build();
}

@Test
void testNull()
{
assertDefaultColumnValue(TINYINT, new NullLiteral(LOCATION));
}

@Test
void testBoolean()
{
Expand All @@ -84,6 +78,7 @@ void testTinyint()
{
assertDefaultColumnValue(TINYINT, new LongLiteral(LOCATION, "-128"));
assertDefaultColumnValue(TINYINT, new LongLiteral(LOCATION, "127"));
assertDefaultColumnValue(TINYINT, new NullLiteral(LOCATION));

assertInvalidDefaultColumnValue(TINYINT, new LongLiteral(LOCATION, "-129"), "Out of range for tinyint: -129");
assertInvalidDefaultColumnValue(TINYINT, new LongLiteral(LOCATION, "128"), "Out of range for tinyint: 128");
Expand All @@ -94,6 +89,7 @@ void testSmallint()
{
assertDefaultColumnValue(SMALLINT, new LongLiteral(LOCATION, "-32768"));
assertDefaultColumnValue(SMALLINT, new LongLiteral(LOCATION, "32767"));
assertDefaultColumnValue(SMALLINT, new NullLiteral(LOCATION));

assertInvalidDefaultColumnValue(SMALLINT, new LongLiteral(LOCATION, "-32769"), " Out of range for smallint: -32769");
assertInvalidDefaultColumnValue(SMALLINT, new LongLiteral(LOCATION, "32768"), " Out of range for smallint: 32768");
Expand All @@ -104,6 +100,7 @@ void testInteger()
{
assertDefaultColumnValue(INTEGER, new LongLiteral(LOCATION, "-2147483648"));
assertDefaultColumnValue(INTEGER, new LongLiteral(LOCATION, "2147483647"));
assertDefaultColumnValue(INTEGER, new NullLiteral(LOCATION));

assertInvalidDefaultColumnValue(INTEGER, new LongLiteral(LOCATION, "-2147483649"), "Out of range for integer: -2147483649");
assertInvalidDefaultColumnValue(INTEGER, new LongLiteral(LOCATION, "2147483648"), "Out of range for integer: 2147483648");
Expand All @@ -114,6 +111,7 @@ void testBigint()
{
assertDefaultColumnValue(BIGINT, new LongLiteral(LOCATION, "-9223372036854775808"));
assertDefaultColumnValue(BIGINT, new LongLiteral(LOCATION, "9223372036854775807"));
assertDefaultColumnValue(BIGINT, new NullLiteral(LOCATION));

// LongLiteral disallows values outside the range of a long
}
Expand All @@ -128,6 +126,7 @@ void testReal()
assertDefaultColumnValue(REAL, new GenericLiteral(LOCATION, "REAL", "NaN"));
assertDefaultColumnValue(REAL, new GenericLiteral(LOCATION, "REAL", "+Infinity"));
assertDefaultColumnValue(REAL, new GenericLiteral(LOCATION, "REAL", "-Infinity"));
assertDefaultColumnValue(REAL, new NullLiteral(LOCATION));
}

@Test
Expand All @@ -141,6 +140,7 @@ void testDouble()
assertDefaultColumnValue(DOUBLE, new GenericLiteral(LOCATION, "DOUBLE", "NaN"));
assertDefaultColumnValue(DOUBLE, new GenericLiteral(LOCATION, "DOUBLE", "+Infinity"));
assertDefaultColumnValue(DOUBLE, new GenericLiteral(LOCATION, "DOUBLE", "-Infinity"));
assertDefaultColumnValue(DOUBLE, new NullLiteral(LOCATION));
}

@Test
Expand All @@ -154,6 +154,8 @@ void testDecimal()
assertDefaultColumnValue(createDecimalType(30, 5), new DecimalLiteral(LOCATION, "-3141592653589793238462643.38327"));
assertDefaultColumnValue(createDecimalType(38), new DecimalLiteral(LOCATION, "27182818284590452353602874713526624977"));
assertDefaultColumnValue(createDecimalType(38), new DecimalLiteral(LOCATION, "-27182818284590452353602874713526624977"));
assertDefaultColumnValue(createDecimalType(3), new NullLiteral(LOCATION));
assertDefaultColumnValue(createDecimalType(38), new NullLiteral(LOCATION));
}

@Test
Expand All @@ -177,6 +179,7 @@ void testChar()
assertDefaultColumnValue(createCharType(10), new StringLiteral(LOCATION, "test"));
assertDefaultColumnValue(createCharType(5), new StringLiteral(LOCATION, "攻殻機動隊"));
assertDefaultColumnValue(createCharType(1), new StringLiteral(LOCATION, "😂"));
assertDefaultColumnValue(createCharType(3), new NullLiteral(LOCATION));
}

@Test
Expand All @@ -200,6 +203,8 @@ void testVarchar()
assertDefaultColumnValue(VARCHAR, new StringLiteral(LOCATION, "test"));
assertDefaultColumnValue(createVarcharType(5), new StringLiteral(LOCATION, "攻殻機動隊"));
assertDefaultColumnValue(createVarcharType(1), new StringLiteral(LOCATION, "😂"));
assertDefaultColumnValue(VARCHAR, new NullLiteral(LOCATION));
assertDefaultColumnValue(createVarcharType(255), new NullLiteral(LOCATION));
}

@Test
Expand Down Expand Up @@ -233,6 +238,9 @@ void testTime()
assertDefaultColumnValue(createTimeType(10), new GenericLiteral(LOCATION, "TIME", "00:00:00.1234567890"));
assertDefaultColumnValue(createTimeType(11), new GenericLiteral(LOCATION, "TIME", "00:00:00.12345678901"));
assertDefaultColumnValue(createTimeType(12), new GenericLiteral(LOCATION, "TIME", "00:00:00.123456789012"));

assertDefaultColumnValue(createTimeType(0), new NullLiteral(LOCATION));
assertDefaultColumnValue(createTimeType(12), new NullLiteral(LOCATION));
}

@Test
Expand All @@ -242,6 +250,7 @@ void testDate()
assertDefaultColumnValue(DATE, new GenericLiteral(LOCATION, "DATE", "1969-12-31"));
assertDefaultColumnValue(DATE, new GenericLiteral(LOCATION, "DATE", "1970-01-01"));
assertDefaultColumnValue(DATE, new GenericLiteral(LOCATION, "DATE", "9999-12-31"));
assertDefaultColumnValue(DATE, new NullLiteral(LOCATION));
}

@Test
Expand Down Expand Up @@ -269,6 +278,9 @@ void testTimestamp()
assertDefaultColumnValue(createTimestampType(12), new GenericLiteral(LOCATION, "TIMESTAMP", "1970-01-01 00:00:00.9999"));
assertDefaultColumnValue(createTimestampType(12), new GenericLiteral(LOCATION, "TIMESTAMP", "1970-01-01 00:00:00.99999"));
assertDefaultColumnValue(createTimestampType(12), new GenericLiteral(LOCATION, "TIMESTAMP", "1970-01-01 00:00:00.999999"));

assertDefaultColumnValue(createTimestampType(0), new NullLiteral(LOCATION));
assertDefaultColumnValue(createTimestampType(12), new NullLiteral(LOCATION));
}

@Test
Expand Down Expand Up @@ -302,6 +314,9 @@ void testTimestampWithTimeZone()
assertDefaultColumnValue(createTimestampWithTimeZoneType(12), new GenericLiteral(LOCATION, "TIMESTAMP", "1970-01-01 00:00:00.9 UTC"));
assertDefaultColumnValue(createTimestampWithTimeZoneType(12), new GenericLiteral(LOCATION, "TIMESTAMP", "1970-01-01 00:00:00.99 UTC"));
assertDefaultColumnValue(createTimestampWithTimeZoneType(12), new GenericLiteral(LOCATION, "TIMESTAMP", "1970-01-01 00:00:00.999 UTC"));

assertDefaultColumnValue(createTimestampWithTimeZoneType(0), new NullLiteral(LOCATION));
assertDefaultColumnValue(createTimestampWithTimeZoneType(12), new NullLiteral(LOCATION));
}

@Test
Expand Down