Recheck that operator is not waiting for memory in hash builder finish #26142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Operator#finish might be called even if operator is blocked (e.g. waiting for memory). Therefore, memory available condition needs to be re-checked every time finish is called.
Member
Author
|
cc @osscm |
pettyjamesm
approved these changes
Jul 8, 2025
Member
pettyjamesm
left a comment
pettyjamesm
left a comment
There was a problem hiding this comment.
LGTM. Seems like the previous behavior could result in unnecessary OOMs? If so, this PR probably merits a release note mention.
Member
Author
It's not guaranteed you will hit OOM without this PR. I will suggest some RN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operator#finish might be called even if operator is blocked (e.g. waiting for memory). Therefore, memory available condition needs to be re-checked every time finish is called.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: