Skip to content

Conversation

@sopel39
Copy link
Member

@sopel39 sopel39 commented Jul 7, 2025

Setting spiller to empty (without closing) caused spill files leak. Spiller is closed when SpillableHashAggregationBuilder is closed.

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## General
* Fix spill files leaking in aggregation queries. ({issue}`issuenumber`)

@sopel39 sopel39 requested a review from raunaqmorarka July 7, 2025 17:54
@cla-bot
Copy link

cla-bot bot commented Jul 7, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Karol Sobczak.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Setting spiller to empty (without closing) caused spill files leak.
Spiller is closed when SpillableHashAggregationBuilder is closed.
@sopel39 sopel39 force-pushed the oss/fix_spill_file_leak branch from 1b1144d to 55a261d Compare July 7, 2025 17:56
@cla-bot cla-bot bot added the cla-signed label Jul 7, 2025
@sopel39
Copy link
Member Author

sopel39 commented Jul 7, 2025

cc @osscm

@sopel39 sopel39 merged commit 9597959 into trinodb:master Jul 8, 2025
94 of 95 checks passed
@sopel39 sopel39 deleted the oss/fix_spill_file_leak branch July 8, 2025 10:35
@github-actions github-actions bot added this to the 477 milestone Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants