Vmhtuan/kafka producer config #26130
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tuấn Vũ Minh.
|
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Please document new config properties in event-listeners-kafka.md, and squash commits into one.
| private Long maxRequestSize = 5242880L; | ||
| private Long batchSize = 16384L; |
There was a problem hiding this comment.
Could you leave a code comment explaining how these values are chosen?
Please use long instead.
There was a problem hiding this comment.
Thank you for reviewing! This PR has some issues, and I have closed it. I have opened a new PR at #26132. And I'm gonna resolve your comments. Thanks!
| return this; | ||
| } | ||
|
|
||
| public Long getMaxRequestSize() |
There was a problem hiding this comment.
getters/setters place should be consistent with fields.
| return maxRequestSize; | ||
| } | ||
|
|
||
| @Config("kafka-event-listener.max-request-size") |
There was a problem hiding this comment.
@ConfigDescription is missing. Same for kafka-event-listener.batch-size
| @Config("kafka-event-listener.max-request-size") | ||
| public KafkaEventListenerConfig setMaxRequestSize(Long maxRequestSize) | ||
| { | ||
| Optional.ofNullable(maxRequestSize).ifPresent(value -> this.maxRequestSize = value); |
There was a problem hiding this comment.
this.maxRequestSize = maxRequestSize;| @Config("kafka-event-listener.batch-size") | ||
| public KafkaEventListenerConfig setBatchSize(Long batchSize) | ||
| { | ||
| Optional.ofNullable(batchSize).ifPresent(value -> this.batchSize = value); |
2 participants
Fixes #26129
Description
Add support for
max.request.sizeandbatch.sizeconfiguration for Kafka producer of Kafka Event ListenerAdditional context and related issues
Release notes
Release notes are required, with the following suggested text: