Skip to content

Add explicitly cast for merge tests in BaseConnectorSmokeTest #26127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025
Merged

Add explicitly cast for merge tests in BaseConnectorSmokeTest #26127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorSmokeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,11 +325,11 @@ public void testRowLevelUpdate()

try (TestTable table = createTestTableForWrites("test_update_")) {
assertUpdate("INSERT INTO " + table.getName() + " (a, b) SELECT regionkey, regionkey * 2.5 FROM region", "SELECT count(*) FROM region");
assertThat(query("SELECT a, b FROM " + table.getName()))
assertThat(query("SELECT CAST(a AS bigint), b FROM " + table.getName()))
.matches(expectedValues("(0, 0.0), (1, 2.5), (2, 5.0), (3, 7.5), (4, 10.0)"));

assertUpdate("UPDATE " + table.getName() + " SET b = b + 1.2 WHERE a % 2 = 0", 3);
assertThat(query("SELECT a, b FROM " + table.getName()))
assertThat(query("SELECT CAST(a AS bigint), b FROM " + table.getName()))
.matches(expectedValues("(0, 1.2), (1, 2.5), (2, 6.2), (3, 7.5), (4, 11.2)"));
}
}
Expand All @@ -351,7 +351,7 @@ public void testMerge()

try (TestTable table = createTestTableForWrites("test_merge_")) {
assertUpdate("INSERT INTO " + table.getName() + " (a, b) SELECT regionkey, regionkey * 2.5 FROM region", "SELECT count(*) FROM region");
assertThat(query("SELECT a, b FROM " + table.getName()))
assertThat(query("SELECT CAST(a AS bigint), b FROM " + table.getName()))
.matches(expectedValues("(0, 0.0), (1, 2.5), (2, 5.0), (3, 7.5), (4, 10.0)"));

assertUpdate("MERGE INTO " + table.getName() + " t " +
Expand All @@ -361,7 +361,7 @@ public void testMerge()
"WHEN MATCHED AND s.b = 0 THEN DELETE " +
"WHEN NOT MATCHED THEN INSERT VALUES (s.a, s.b)",
4);
assertThat(query("SELECT a, b FROM " + table.getName()))
assertThat(query("SELECT CAST(a AS bigint), b FROM " + table.getName()))
.matches(expectedValues("(0, 1.3), (1, 2.5), (2, 7.9), (4, 10.0), (5, 5.7)"));
}
}
Expand Down
Loading