Replace Joda-Time DateTime with java.time.Instant #25988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/instant-times
branch
4 times, most recently
from
3a3aae3 to
ca9507b
Compare
wendigo
force-pushed
the
serafin/instant-times
branch
2 times, most recently
from
232ce25 to
885bfa8
Compare
wendigo
force-pushed
the
serafin/instant-times
branch
from
885bfa8 to
a034eb2
Compare
raunaqmorarka
approved these changes
Jun 11, 2025
Switched from Joda-Time DateTime to java.time.Instant for measuring timings. This aligns with how the values are already being used—primarily for durations rather than calendar-based datetimes. Using Instant is more semantically appropriate and consistent with the rest of the codebase. Additionally, Instant is a @valuebased class, allowing potential performance optimizations in newer Java versions.
wendigo
force-pushed
the
serafin/instant-times
branch
from
a034eb2 to
3b255ff
Compare
wendigo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched from Joda-Time DateTime to java.time.Instant for measuring timings. This aligns with how the values
are already being used—primarily for durations rather than calendar-based datetimes. Using Instant is more
semantically appropriate and consistent with the rest of the codebase. Additionally, Instant is a @valuebased class,
allowing potential performance optimizations in newer Java versions.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: