Skip to content

Improve error classification in Iceberg connector #25982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

Improve error classification in Iceberg connector #25982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import io.trino.plugin.base.classloader.ClassLoaderSafeConnectorMetadata;
import io.trino.plugin.base.session.SessionPropertiesProvider;
import io.trino.plugin.hive.HiveTransactionHandle;
import io.trino.spi.TrinoException;
import io.trino.spi.connector.Connector;
import io.trino.spi.connector.ConnectorAccessControl;
import io.trino.spi.connector.ConnectorCapabilities;
Expand All @@ -39,13 +40,15 @@
import io.trino.spi.procedure.Procedure;
import io.trino.spi.session.PropertyMetadata;
import io.trino.spi.transaction.IsolationLevel;
import org.apache.iceberg.exceptions.RESTException;

import java.util.List;
import java.util.Optional;
import java.util.Set;

import static com.google.common.collect.ImmutableList.toImmutableList;
import static com.google.common.collect.Sets.immutableEnumSet;
import static io.trino.plugin.iceberg.IcebergErrorCode.ICEBERG_CATALOG_ERROR;
import static io.trino.spi.connector.ConnectorCapabilities.MATERIALIZED_VIEW_GRACE_PERIOD;
import static io.trino.spi.connector.ConnectorCapabilities.NOT_NULL_COLUMN_CONSTRAINT;
import static io.trino.spi.transaction.IsolationLevel.SERIALIZABLE;
Expand Down Expand Up @@ -128,8 +131,13 @@ public Set<ConnectorCapabilities> getCapabilities()
@Override
public ConnectorMetadata getMetadata(ConnectorSession session, ConnectorTransactionHandle transaction)
{
ConnectorMetadata metadata = transactionManager.get(transaction, session.getIdentity());
return new ClassLoaderSafeConnectorMetadata(metadata, getClass().getClassLoader());
try {
ConnectorMetadata metadata = transactionManager.get(transaction, session.getIdentity());
return new ClassLoaderSafeConnectorMetadata(metadata, getClass().getClassLoader());
}
catch (RESTException e) {
throw new TrinoException(ICEBERG_CATALOG_ERROR, "Cannot obtain metadata", e);
}
}

@Override
Expand Down