Skip to content

Conversation

@brendanstennett
Copy link
Contributor

@brendanstennett brendanstennett commented Jun 11, 2025

Fixes #25972

Description

This allows supporting of PostgreSQL PostGIS geometry types when the extension is installed on a schema other than public.

Additional context and related issues

Currently if PostGIS is installed on a schema other than public, the Geometry type column will not be recognized or will appear as a varchar if CONVERT_TO_VARCHAR is set. This fixes this bug and will allow use of Geometry types when this extension is installed on another schema.

Before change

Screenshot 2025-06-10 at 9 29 54 PM

After change

Screenshot 2025-06-10 at 9 30 05 PM

Release notes

## PostgreSQL
* Add support for `geometry` types installed in schemas other than `public`. ({issue}`25972`)

@cla-bot cla-bot bot added the cla-signed label Jun 11, 2025
@github-actions github-actions bot added the postgresql PostgreSQL connector label Jun 11, 2025
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebyhr
Copy link
Member

ebyhr commented Jun 11, 2025

Could you test this change locally and attach the screenshot in the PR description?

@brendanstennett brendanstennett changed the title Postgres support for postgis ext on schema other than public Support PostGIS extension on non-public schemas in PostgreSQL Jun 11, 2025
@brendanstennett
Copy link
Contributor Author

@ebyhr Sure thing! Updated commit message and attached screenshots from the local testing I did

@ebyhr ebyhr merged commit 09ef005 into trinodb:master Jun 11, 2025
20 checks passed
@github-actions github-actions bot added this to the 477 milestone Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed postgresql PostgreSQL connector

Development

Successfully merging this pull request may close these issues.

PostGIS support only works if postgis is installed in the public schema

2 participants