Refactor Delta Lake transaction log handling #25927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjian2664
requested review from
ebyhr,
findinpath and
raunaqmorarka
and removed request for
ebyhr
chenjian2664
force-pushed
the
ref_delta_613
branch
from
61bbabc to
a01ca71
Compare
Introduce `TransactionLogReader` and `TransactionLogWriter` to encapsulate the logic for reading and writing the transaction log. This abstraction improves code clarity and makes it easier to extend functionality in the future.
Simplify usage by allowing `TransactionLogAccess` to directly use an injected `TransactionLogReaderFactory`, removing the need for callers to pass it conditionally.
chenjian2664
force-pushed
the
ref_delta_613
branch
from
a01ca71 to
96c4ed2
Compare
Member
|
/test-with-secrets sha=96c4ed28f04c81468edeb2d5d939b097b446e433 |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/15458570382 |
ebyhr
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce
TransactionLogReaderandTransactionLogWritertoencapsulate the logic for reading and writing the transaction log.
This abstraction improves code clarity and makes it easier to
extend functionality in the future.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.