Make softMemoryLimit optional in resource group spec #25916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softMemoryLimit was previously required. However, it's often unclear for the users what is the implication of setting the limit and it doesn't work well will revocable memory and spilled queries. This PR makes softMemoryLimit optional and allows to manage query concurrency within query classes (e.g. small, medium, large) which greatly simplifies cluster management.
raunaqmorarka
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
softMemoryLimit was previously required. However, it's often unclear for the users what is the implication of setting the limit and it doesn't work well will revocable memory and spilled queries.
This PR makes softMemoryLimit optional and allows to manage query concurrency within query classes (e.g. small, medium, large) which greatly simplifies cluster management.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: