Refactor TransactionLogTail#loadNewTail method
#25856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjian2664
requested review from
ebyhr and
raunaqmorarka
and removed request for
ebyhr
chenjian2664
force-pushed
the
logtail_merge
branch
from
6c9c215 to
39eb6b8
Compare
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
chenjian2664
force-pushed
the
logtail_merge
branch
from
39eb6b8 to
89e45ad
Compare
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
...ke/src/main/java/io/trino/plugin/deltalake/transactionlog/checkpoint/TransactionLogTail.java
Outdated
Show resolved
Hide resolved
...ke/src/main/java/io/trino/plugin/deltalake/transactionlog/checkpoint/TransactionLogTail.java
Outdated
Show resolved
Hide resolved
...ke/src/main/java/io/trino/plugin/deltalake/transactionlog/checkpoint/TransactionLogTail.java
Show resolved
Hide resolved
...ke/src/main/java/io/trino/plugin/deltalake/transactionlog/checkpoint/TransactionLogTail.java
Outdated
Show resolved
Hide resolved
...ke/src/main/java/io/trino/plugin/deltalake/transactionlog/checkpoint/TransactionLogTail.java
Outdated
Show resolved
Hide resolved
chenjian2664
force-pushed
the
logtail_merge
branch
from
89e45ad to
6b64b0b
Compare
chenjian2664
force-pushed
the
logtail_merge
branch
from
6b64b0b to
c864c50
Compare
...ke/src/main/java/io/trino/plugin/deltalake/transactionlog/checkpoint/TransactionLogTail.java
Outdated
Show resolved
Hide resolved
...ke/src/main/java/io/trino/plugin/deltalake/transactionlog/checkpoint/TransactionLogTail.java
Show resolved
Hide resolved
...ke/src/main/java/io/trino/plugin/deltalake/transactionlog/checkpoint/TransactionLogTail.java
Show resolved
Hide resolved
chenjian2664
force-pushed
the
logtail_merge
branch
from
c864c50 to
5dd5f53
Compare
...ke/src/main/java/io/trino/plugin/deltalake/transactionlog/checkpoint/TransactionLogTail.java
Outdated
Show resolved
Hide resolved
...ke/src/main/java/io/trino/plugin/deltalake/transactionlog/checkpoint/TransactionLogTail.java
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/BaseTransactionsTable.java
Show resolved
Hide resolved
...ke/src/main/java/io/trino/plugin/deltalake/transactionlog/checkpoint/TransactionLogTail.java
Show resolved
Hide resolved
chenjian2664
force-pushed
the
logtail_merge
branch
2 times, most recently
from
56dc2ec to
a4b73ab
Compare
Refactor TransactionLogTail#loadNewTail to support loading transaction log to based on param `startVersion` and `endVersion` conditional. Previously, the method only supported forward traversal from head to tail, which posed a risk when early transaction logs were missing -- maybe due to cleanup. This refactor enables both forward and backward traversal, increasing robustness and flexibility in tail loading logic. Additionally, remove `BaseTransactionsTable#loadNewTailBackward` and use the enhanced loadNewTail method.
chenjian2664
force-pushed
the
logtail_merge
branch
from
a4b73ab to
92df66e
Compare
raunaqmorarka
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
TransactionLogTail#loadNewTailto support loading transaction log to based on paramstartVersionandendVersionconditional. Previously, the method only supported forward traversal from head to tail, which posed a risk when early transaction logs were missing -- maybe due to cleanup. This refactor enables both forward and backward traversal, increasing robustness and flexibility in tail loading logic.Additionally, remove
BaseTransactionsTable#loadNewTailBackwardand use the enhanced loadNewTail method.Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: