-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Ensure that createViewSession preserves the trace token #25716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that createViewSession preserves the trace token #25716
Conversation
ab8ebfe to
323b87a
Compare
ksobolew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks simple enough. Is it possible to add a test?
|
This looks good to me, but if a test is possible, please add that. If not (or really annoying), please let us know, and one of us will merge it as is. |
|
@huw0 For testing I think we could use |
f82bae1 to
5e91edf
Compare
|
I've added some unit testing around |
|
Instead of this test - WDYT about #25716 (comment) ? |
5e91edf to
4444b50
Compare
|
@Praveen2112 - I've added an additional commit with an alternative test using the approach you've outlined. I've realised that this new test isn't actually hitting the |
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
@dain @Praveen2112 - Please see comment above. I'd like to get this merged soon if there are no objections? |
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
509e048 to
26a60ba
Compare
|
Dropped 3rd commit and rebased. |
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
|
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
26a60ba to
156b813
Compare
|
PR updated against latest master - but otherwise unchanged. |
156b813 to
1239b95
Compare
|
Thanks @raunaqmorarka for review and merge. |
Description
Session.createViewSessioncreates a new Session that is used when analysing views.Presently this does not pass through the trace token. This is breaking the use of views with our custom connectors which mandate that this token is populated.
Therefore this is a very simple PR to ensure that the trace token is populated in
createViewSessionif it is present on the outer session.Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: