Add support for GRANT/DENY/REVOKE on branches #25152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/iceberg-branching-v3
branch
5 times, most recently
from
8322da8 to
03d2d0d
Compare
ebyhr
force-pushed
the
ebi/iceberg-branching-v3
branch
from
03d2d0d to
8eee28a
Compare
ebyhr
force-pushed
the
ebi/iceberg-branching-v3
branch
11 times, most recently
from
96303ed to
611d6cd
Compare
ebyhr
force-pushed
the
ebi/iceberg-branching-v3
branch
from
611d6cd to
4c6df1f
Compare
ebyhr
changed the title
ebyhr
changed the title
ebyhr
force-pushed
the
ebi/iceberg-branching-v3
branch
3 times, most recently
from
0b7aa49 to
91bc773
Compare
|
awesome PR! |
findinpath
reviewed
Apr 22, 2025
core/trino-grammar/src/main/antlr4/io/trino/grammar/sql/SqlBase.g4
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/iceberg-branching-v3
branch
from
91bc773 to
a02b041
Compare
ebyhr
force-pushed
the
ebi/iceberg-branching-v3
branch
from
a02b041 to
8b641c2
Compare
ebyhr
force-pushed
the
ebi/iceberg-branching-v3
branch
from
8b641c2 to
e735a89
Compare
kasiafi
reviewed
Jun 27, 2025
core/trino-main/src/main/java/io/trino/execution/GrantTask.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/security/AccessControlManager.java
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/security/SqlStandardAccessControl.java
Show resolved
Hide resolved
kasiafi
reviewed
Jun 27, 2025
ebyhr
force-pushed
the
ebi/iceberg-branching-v3
branch
from
e735a89 to
5c15495
Compare
ebyhr
changed the title
ebyhr
force-pushed
the
ebi/iceberg-branching-v3
branch
4 times, most recently
from
c3b9148 to
6c8b7f7
Compare
kasiafi
approved these changes
Jul 21, 2025
| metadata.denyTablePrivileges(session, tableName, privileges, createPrincipal(statement.getGrantee())); | ||
| } | ||
| else { | ||
| String branchName = branch.get().getValue(); |
There was a problem hiding this comment.
We don't have proper Identifier semantics in Trino, but it would be closer to correct if we used getCanonicalValue() instead of getValue().
However, I just noticed that we also rely on getValue() when creating the branch...
On the other hand, when creating a QualifiedName, we rely on this method, which lowercases identifiers.
I think that for branches, we should also lowercase the name to keep it locally consistent.
Same applies to GrantTask and RevokeTask.
@martint what do you think?
There was a problem hiding this comment.
I will send a follow-up PR if Martin request changes.
core/trino-main/src/main/java/io/trino/metadata/SystemSecurityMetadata.java
Outdated
Show resolved
Hide resolved
core/trino-parser/src/main/java/io/trino/sql/parser/AstBuilder.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/security/SystemAccessControl.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/iceberg-branching-v3
branch
from
6c8b7f7 to
ec04151
Compare
ebyhr
force-pushed
the
ebi/iceberg-branching-v3
branch
from
ec04151 to
6c3100c
Compare
This was referenced Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Syntax proposal: https://docs.google.com/document/d/1jEF4IkWu-2Gzk5ii2Nb0exuEnAUeo98UbiM3i0xtgWQ/edit?usp=sharing
This adds a new privilege
CREATE BRANCHfor access control of branches.Relates to #12844
Release notes