Skip to content

Document wildcard tables query support#25108

Merged
mosabua merged 1 commit intotrinodb:masterfrom
findinpath:findinpath/docs-wildcard-tables
Feb 22, 2025
Merged

Document wildcard tables query support#25108
mosabua merged 1 commit intotrinodb:masterfrom
findinpath:findinpath/docs-wildcard-tables

Conversation

@findinpath
Copy link
Copy Markdown
Contributor

@findinpath findinpath commented Feb 21, 2025

Description

Additional context and related issues

https://cloud.google.com/bigquery/docs/querying-wildcard-tables

https://www.elastic.co/guide/en/elasticsearch/reference/current/search-multiple-indices.html

https://opensearch.org/docs/latest/api-reference/multi-search/#metadata-only-options

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting from https://cloud.google.com/bigquery/docs/querying-wildcard-tables

Each row in the wildcard table contains a special column, _TABLE_SUFFIX, which contains the value matched by the wildcard character.

Maybe it is worth exposing this hidden column for this specific use case in a follow-up (if this functionality has any traction).
cc @ebyhr

Copy link
Copy Markdown
Member

@Ordinant Ordinant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me.

Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At minimum we need to link to other resources that explain what these tables are and what restrictions there are on it. Or better would be if we document ourselves..

Also is this just passing through to the underlying system or is this actually running in Trino .. and what are limitations in terms of WHERE clauses or JOINs or whatever.

For example, I would think that if you have to table .. tbl1 and tbl2 with completely different columns .. doing a wildcard query on them wont work ..

@findinpath findinpath force-pushed the findinpath/docs-wildcard-tables branch from b6fd981 to 02a9e70 Compare February 21, 2025 23:43
@findinpath
Copy link
Copy Markdown
Contributor Author

At minimum we need to link to other resources that explain what these tables are and what restrictions there are on it. Or better would be if we document ourselves..

I decided on linking to other resources option - the data source providers themselves don't specify explicitly the limitations, so I don't see a reason why we should attempt to specify the limitations ourselves.

@findinpath findinpath force-pushed the findinpath/docs-wildcard-tables branch from 02a9e70 to 23f2b12 Compare February 21, 2025 23:47
@findinpath findinpath requested a review from mosabua February 21, 2025 23:47
@findinpath findinpath force-pushed the findinpath/docs-wildcard-tables branch from 23f2b12 to ab77929 Compare February 21, 2025 23:48
@findinpath findinpath force-pushed the findinpath/docs-wildcard-tables branch from ab77929 to 5358feb Compare February 22, 2025 00:05
Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@mosabua mosabua merged commit 60926f9 into trinodb:master Feb 22, 2025
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Feb 22, 2025

Thank you @findinpath !

@github-actions github-actions bot added this to the 472 milestone Feb 22, 2025
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Feb 24, 2025

Related question .. do we need to backfill this feature into some old release notes @findinpath ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants