Skip to content

Fix logic for hadling missing final task info#25080

Merged
losipiuk merged 2 commits intotrinodb:masterfrom
losipiuk:lukaszos/fix-logic-for-hadling-missing-final-task-info-94800e
Feb 19, 2025
Merged

Fix logic for hadling missing final task info#25080
losipiuk merged 2 commits intotrinodb:masterfrom
losipiuk:lukaszos/fix-logic-for-hadling-missing-final-task-info-94800e

Conversation

@losipiuk
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@raunaqmorarka raunaqmorarka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any way to test it ?

@losipiuk
Copy link
Copy Markdown
Member Author

any way to test it ?

We would need a minute long query in test (1 minut is delay for triggering the detector). Shorter queries are completed by then and even bug in detector does not do harm.
I can add one

@losipiuk losipiuk force-pushed the lukaszos/fix-logic-for-hadling-missing-final-task-info-94800e branch from b308593 to 92e877f Compare February 19, 2025 13:14
@cla-bot cla-bot bot added the cla-signed label Feb 19, 2025
@losipiuk losipiuk force-pushed the lukaszos/fix-logic-for-hadling-missing-final-task-info-94800e branch from 92e877f to af1d7a6 Compare February 19, 2025 13:15
@losipiuk losipiuk force-pushed the lukaszos/fix-logic-for-hadling-missing-final-task-info-94800e branch from af1d7a6 to dac00cc Compare February 19, 2025 13:18
@losipiuk losipiuk merged commit 2a12ff8 into trinodb:master Feb 19, 2025
@github-actions github-actions bot added this to the 471 milestone Feb 19, 2025
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Feb 19, 2025

Release blocker but no release notes entry?

@losipiuk
Copy link
Copy Markdown
Member Author

Release blocker but no release notes entry?

yep.
issue was not released yet.

@losipiuk losipiuk added the no-release-notes This pull request does not require release notes entry label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry RELEASE-BLOCKER

Development

Successfully merging this pull request may close these issues.

4 participants