Support write large checkpoint in Delta Lake#25078
Support write large checkpoint in Delta Lake#25078raunaqmorarka merged 1 commit intotrinodb:masterfrom
Conversation
|
wondering how to add test |
Try adding a unit test which has sufficient entries to go over PageBuilder size threshold |
How to know the entries size is sufficient is enough or not, is 1k insert enough? does it make sense? |
Just use a debugger to see when the page builder gets full and use some size significantly above that |
df6f1b2 to
85383eb
Compare
85383eb to
92f9878
Compare
| throws IOException | ||
| { | ||
| flush(); | ||
| writer.close(); |
There was a problem hiding this comment.
do we maybe need
try{
flush();
} finally {
writer.close();
}
Description
Close #25011
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: