Remove Connector.getInitialMemoryRequirement()#25055
Merged
electrum merged 1 commit intotrinodb:masterfrom Feb 18, 2025
Merged
Conversation
Member
|
For the new implementation, the reservation API should be passed in the ConnectorContext object. |
wendigo
approved these changes
Feb 18, 2025
electrum
force-pushed
the
remove-memory
branch
from
64cbcbd to
c0c125a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This functionality is not used by any connector in Trino, nor is it tested. This functionality should be replaced with a memory reservation API that is passed into the connector. We could then have the memory connector declare its used memory, the Hive connector could report memory used for caches, etc.
Release notes
(x) Release notes are required, with the following suggested text: