Do not use PostConstruct for config validation#25048
Merged
losipiuk merged 2 commits intotrinodb:masterfrom Feb 17, 2025
Merged
Conversation
github-actions
bot
added
hive
wendigo
reviewed
Feb 17, 2025
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryConfig.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Feb 17, 2025
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryConfig.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Feb 17, 2025
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryProxyConfig.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Feb 17, 2025
...trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/v1/GlueHiveMetastoreConfig.java
Outdated
Show resolved
Hide resolved
wendigo
approved these changes
Feb 17, 2025
losipiuk
force-pushed
the
lukaszos/do-not-use-postconstruct-for-config-validation-100b84
branch
2 times, most recently
from
24e4535 to
0c89e90
Compare
losipiuk
force-pushed
the
lukaszos/do-not-use-postconstruct-for-config-validation-100b84
branch
from
0c89e90 to
6ab9d3d
Compare
Member
|
Could you explain the motivation? Can we ban |
Contributor
|
@hashhar we should. PostConstruct is for life cycle management when all of the dependencies are resolved correctly and graph is fully built. In this case we want to validate config which happens earlier, during graph construction and is reported differently. One will be an actionable failure (validation) and the other will not (you will get an exception from lifecycle manager) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: