Skip to content

Expose local filesystem#25006

Merged
wendigo merged 1 commit intomasterfrom
serafin/expose-local-filesystem
Feb 17, 2025
Merged

Expose local filesystem#25006
wendigo merged 1 commit intomasterfrom
serafin/expose-local-filesystem

Conversation

@wendigo
Copy link
Copy Markdown
Contributor

@wendigo wendigo commented Feb 13, 2025

Description

Additional context and related issues

Docs in #25001

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## Iceberg/Delta/Hive
* Add support for local filesystem ({issue}`issuenumber`)

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Feb 13, 2025

Do we need a test with a full config file example or so?

@wendigo
Copy link
Copy Markdown
Contributor Author

wendigo commented Feb 13, 2025

Wdym? The local filesystem is used in number of tests so it's well covered

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Feb 13, 2025

Wdym? The local filesystem is used in number of tests so it's well covered

Cool .. just wanted to make sure ..

Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably have more questions in the docs PR but this is a great step. Also .. @electrum essentially approved moving forward with this on slack .. just didnt look at the code just yet.

@wendigo
Copy link
Copy Markdown
Contributor Author

wendigo commented Feb 13, 2025

@mosabua I believe this is the only place needed to support it in the connector :)

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Feb 13, 2025

I updated the docs PR now with what I think you need to do .. but I am entirely unsure about the local.location property .. there is no config class or anything.

@wendigo wendigo force-pushed the serafin/expose-local-filesystem branch from bc59009 to 7537029 Compare February 14, 2025 12:32
@wendigo
Copy link
Copy Markdown
Contributor Author

wendigo commented Feb 14, 2025

@mosabua yeah, you are right, I've added a config :)

@wendigo wendigo force-pushed the serafin/expose-local-filesystem branch from 7537029 to 989ce5b Compare February 14, 2025 14:20
Add local.location being a root of all local files accessible through the filesystem
@wendigo wendigo force-pushed the serafin/expose-local-filesystem branch from 989ce5b to 0273f82 Compare February 14, 2025 15:12
@wendigo wendigo merged commit e48390b into master Feb 17, 2025
@wendigo wendigo deleted the serafin/expose-local-filesystem branch February 17, 2025 11:05
@github-actions github-actions bot added this to the 471 milestone Feb 17, 2025
@krutoileshii
Copy link
Copy Markdown

Is there an example of create table with local storage for iceberg?

https://trino.io/docs/current/connector/iceberg.html

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Mar 6, 2025

Is there an example of create table with local storage for iceberg?

https://trino.io/docs/current/connector/iceberg.html

Not at this stage .. if you test and use it .. send a docs PR please. The only other thing you can look at are the tests in the codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants