Skip to content

Fix duplicate key due to non-lowercase collections in MongoDB #24998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Feb 13, 2025
+38 −1
Merged

Fix duplicate key due to non-lowercase collections in MongoDB #24998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,9 @@ public Set<String> getAllTables(String schema)
.collect(toSet()));
builder.addAll(getTableMetadataNames(schemaName));

return builder.build();
return builder.build().stream()
.map(name -> name.toLowerCase(ENGLISH))
.collect(toImmutableSet());
}

public MongoTable getTable(SchemaTableName tableName)
Expand Down
35 changes: 35 additions & 0 deletions plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
import static io.trino.testing.TestingNames.randomNameSuffix;
import static java.lang.String.format;
import static java.nio.charset.StandardCharsets.UTF_8;
import static java.util.Locale.ENGLISH;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.junit.jupiter.api.Assumptions.abort;
Expand Down Expand Up @@ -149,6 +150,40 @@ public void testSortItemsReflectedInExplain()
"TopNPartial\\[count = 5, orderBy = \\[nationkey DESC");
}

@Test
void testNonLowercaseCollection()
{
String suffix = randomNameSuffix();
String schema = "test_db_" + suffix;
String table = "test_collection_" + suffix;
String mixedTable = "Test_Collection_" + suffix;
try {
MongoDatabase db = client.getDatabase(schema);

db.createCollection(table);
db.getCollection(table).insertOne(new Document("lowercase", 1));

db.createCollection(mixedTable);
db.getCollection(mixedTable).insertOne(new Document("mixed", 2));

assertThatThrownBy(() -> client.getDatabase(schema.toUpperCase(ENGLISH)).createCollection(table))
.hasMessageContaining("db already exists with different case");

db.createCollection(table.toUpperCase(ENGLISH));
db.getCollection(table.toUpperCase(ENGLISH)).insertOne(new Document("uppercase", 3));

assertThat(query("SELECT * FROM information_schema.tables WHERE table_catalog = 'mongodb' AND table_schema = '" + schema + "'"))
.matches("VALUES (VARCHAR 'mongodb', VARCHAR '" + schema + "', VARCHAR '" + table + "', VARCHAR 'BASE TABLE')");
assertThat(query("SELECT table_name, column_name FROM information_schema.columns WHERE table_catalog = 'mongodb' AND table_schema = '" + schema + "'"))
.matches("VALUES (VARCHAR '" + table + "', VARCHAR 'lowercase')");
Comment thread
ebyhr marked this conversation as resolved.
Outdated
assertThat(query("SELECT * FROM " + schema + "." + table))
.matches("VALUES BIGINT '1'");
}
finally {
client.getDatabase(schema).drop();
}
}

@Override
protected Optional<DataMappingTestSetup> filterDataMappingSmokeTestData(DataMappingTestSetup dataMappingTestSetup)
{
Expand Down