Skip to content

Improve PipelinedStageExecution failure message #24978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wendigo merged 1 commit into from
Feb 11, 2025
Merged

Improve PipelinedStageExecution failure message #24978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions core/trino-main/src/main/java/io/trino/execution/scheduler/PipelinedStageExecution.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,15 +352,15 @@ private void updateTaskStatus(TaskStatus taskStatus)
.map(this::rewriteTransportFailure)
.map(ExecutionFailureInfo::toException)
// task is failed or failing, so we need to create a synthetic exception to fail the stage now
.orElseGet(() -> new TrinoException(GENERIC_INTERNAL_ERROR, "A task failed for an unknown reason"));
.orElseGet(() -> new TrinoException(GENERIC_INTERNAL_ERROR, format("Task %s failed for an unknown reason", taskStatus.getTaskId())));
fail(failure);
break;
case CANCELING:
case CANCELED:
case ABORTING:
case ABORTED:
// A task should only be in the aborting, aborted, canceling, or canceled state if the STAGE is done (ABORTED or FAILED)
fail(new TrinoException(GENERIC_INTERNAL_ERROR, format("A task is in the %s state but stage is %s", taskState, stateMachine.getState())));
fail(new TrinoException(GENERIC_INTERNAL_ERROR, format("Task %s is in the %s state but stage %s is %s", taskStatus.getTaskId(), taskState, stateMachine.getStageId(), stateMachine.getState())));
break;
case FLUSHING:
newFlushingOrFinishedTaskObserved = addFlushingTask(taskStatus.getTaskId());
Expand Down Expand Up @@ -601,6 +601,11 @@ private PipelinedStageStateMachine(StageId stageId, Executor executor)
state.addStateChangeListener(state -> log.debug("Pipelined stage execution %s is %s", stageId, state));
}

public StageId getStageId()
{
return stageId;
}

public State getState()
{
return state.get();
Expand Down