Skip to content

Prevent query blocking if final query info is lost #24958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
losipiuk merged 1 commit into from
Feb 8, 2025
Merged

Prevent query blocking if final query info is lost #24958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions ...va/io/trino/execution/scheduler/faulttolerant/EventDrivenFaultTolerantQueryScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@
import java.util.concurrent.ExecutorService;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicLong;
import java.util.concurrent.atomic.AtomicReference;
Expand Down Expand Up @@ -1659,6 +1660,33 @@ public Void onSinkInstanceHandleAcquired(SinkInstanceHandleAcquiredEvent sinkIns
nodeLease.release();
}
});

// we observed it may happen that final task info notification may be lost.
// in such case query progression will be blocked.
// the code below is a stop-gap to mitigate this issue and unblock or fail query
// until we find and fix the bug
AtomicBoolean finalTaskInfoReceived = new AtomicBoolean();
task.addStateChangeListener(taskStatus -> {
if (!taskStatus.getState().isDone()) {
return;
}
switch (taskStatus.getState()) {
case FINISHED -> scheduledExecutorService.schedule(() -> {
if (!finalTaskInfoReceived.get()) {
log.error("Did not receive final task info for task %s after it FINISHED; internal inconsistency; failing query", task.getTaskId());
queryStateMachine.transitionToFailed(new TrinoException(GENERIC_INTERNAL_ERROR, "Did not receive final task info for task after it finished; failing query"));
}
}, 1, MINUTES);
case CANCELED, ABORTED, FAILED -> scheduledExecutorService.schedule(() -> {
if (!finalTaskInfoReceived.get()) {
log.error("Did not receive final task info for task %s after it %s; internal inconsistency; marking task failed in scheduler to unblock query progression", taskStatus.getState(), task.getTaskId());
eventQueue.add(new RemoteTaskCompletedEvent(taskStatus));
}
}, 1, MINUTES);
default -> throw new IllegalStateException("Unexpected task state: " + taskStatus.getState());
}
});

task.addFinalTaskInfoListener(taskExecutionStats::update);
task.addFinalTaskInfoListener(taskInfo -> eventQueue.add(new RemoteTaskCompletedEvent(taskInfo.taskStatus())));
nodeLease.attachTaskId(task.getTaskId());
Expand Down