Skip to content

Fix an issue that causes the restoreStatus in listing response always be empty for glacier objects#24947

Merged
pettyjamesm merged 1 commit intotrinodb:masterfrom
zhaner08:fix_restored_glacier_read
Feb 11, 2025
Merged

Fix an issue that causes the restoreStatus in listing response always be empty for glacier objects#24947
pettyjamesm merged 1 commit intotrinodb:masterfrom
zhaner08:fix_restored_glacier_read

Conversation

@zhaner08
Copy link
Copy Markdown
Contributor

@zhaner08 zhaner08 commented Feb 7, 2025

Description

Fix an issue that causes the restoreStatus always be empty for glacier objects.

If setting READ_NON_GLACIER_AND_RESTORED as the filter, restored glacier objects will be ignored without this changing causing wrong incorrect results.

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( X) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Hive
* Fixes an issue where restored S3 glacier objects should have been considered readable when the configuration property hive.s3.storage-class-filter is set to  READ_NON_GLACIER_AND_RESTORED, but were being skipped instead ({issue}`24947`)

@cla-bot cla-bot bot added the cla-signed label Feb 7, 2025
@zhaner08 zhaner08 requested a review from pettyjamesm February 7, 2025 04:04
@zhaner08 zhaner08 self-assigned this Feb 7, 2025
Comment thread lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3FileSystem.java Outdated
@zhaner08 zhaner08 force-pushed the fix_restored_glacier_read branch from c0ce34e to e566d9e Compare February 10, 2025 19:55
@zhaner08 zhaner08 changed the title Fix an issue that causes the restoreStatus always be empty for glacier objects Fix an issue that causes the restoreStatus in listing response always be empty for glacier objects Feb 10, 2025
@zhaner08
Copy link
Copy Markdown
Contributor Author

Updated the commit message in the latest revision

Copy link
Copy Markdown
Member

@pettyjamesm pettyjamesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zhaner08

@pettyjamesm pettyjamesm merged commit f0cb98e into trinodb:master Feb 11, 2025
@github-actions github-actions bot added this to the 471 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants