Fix TDigestHistogram -> DistributionSnapshot convertion#24933
Merged
losipiuk merged 1 commit intotrinodb:masterfrom Feb 6, 2025
Conversation
wendigo
approved these changes
Feb 6, 2025
Contributor
|
typo in the commit message: conversion |
wendigo
reviewed
Feb 6, 2025
core/trino-main/src/main/java/io/trino/execution/DistributionSnapshot.java
Outdated
Show resolved
Hide resolved
lukasz-stec
approved these changes
Feb 6, 2025
Member
lukasz-stec
left a comment
lukasz-stec
left a comment
There was a problem hiding this comment.
great find, lgtm % comments
core/trino-main/src/main/java/io/trino/execution/DistributionSnapshot.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/DistributionSnapshot.java
Outdated
Show resolved
Hide resolved
Percentiles were calculated incorrectly. As a result DistributionSnapshot stored in final query info were incorrect.
losipiuk
force-pushed
the
lukaszos/fix-tdigesthistogram-distributionsnapshot-convertion-4653c2
branch
from
35ffe4a to
8d36762
Compare
Member
|
no release notes entry? |
losipiuk
added
the
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Percentiles were calculated incorrectly.
As a result DistributionSnapshot stored in final query info were incorrect.