Prohibit use of Files util class from AssertJ to create temporary directories#24931
Merged
wendigo merged 4 commits intotrinodb:masterfrom Feb 10, 2025
Merged
Prohibit use of Files util class from AssertJ to create temporary directories#24931wendigo merged 4 commits intotrinodb:masterfrom
Files util class from AssertJ to create temporary directories#24931wendigo merged 4 commits intotrinodb:masterfrom
Conversation
These changes are all related, so they are in a separate commit not to mix with others.
The remaining cases.
This is a general modernization, as from replacing the `Files` class with `@TempDir` follows replacing `File` with `Path` and related changes like using `Files#copy` from the JDK instead of from Guava, and from most of that follows better (more explicit) exception handling. And all of this is tightly intertwined.
...to create temporary directories, at least. `@TempDir` should be used where possible, and `Files` from the JDK otherwise.
ksobolew
force-pushed
the
kudi/temp-dir
branch
from
b1ac401 to
33e6448
Compare
kokosing
approved these changes
Feb 6, 2025
Member
|
Move the removals of |
Contributor
Author
They are related in a sense that the JDK |
Member
|
If they are related, it’s ok to leave them. I thought I saw some places where they were being removed, but I may have misread the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@TempDirshould be used where possible, andFilesfrom the JDK otherwise.Additional context and related issues
There are plenty of other places where
@TempDircould be used - left as a follow-up.Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: