Skip to content

Clarify Trino behavior when client does not fetch results in Client Potocol#24905

Merged
mosabua merged 3 commits intotrinodb:masterfrom
EdenKik:client-protocol-limitation-mention-in-docs
Feb 10, 2025
Merged

Clarify Trino behavior when client does not fetch results in Client Potocol#24905
mosabua merged 3 commits intotrinodb:masterfrom
EdenKik:client-protocol-limitation-mention-in-docs

Conversation

@EdenKik
Copy link
Copy Markdown
Contributor

@EdenKik EdenKik commented Feb 5, 2025

Description

Clarification in Trino documentation to promote a solution to the issue discussed here -
https://trinodb.slack.com/archives/CP1MUNEUX/p1738607909072639?thread_ts=1738607909.072639&cid=CP1MUNEUX

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Feb 5, 2025
@github-actions github-actions bot added the docs label Feb 5, 2025
@wendigo wendigo requested a review from mosabua February 5, 2025 10:06
Comment thread docs/src/main/sphinx/client/client-protocol.md Outdated
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Feb 5, 2025

Maybe we should also detail the final response when the query is done .. I believe its just FINISHED but @wendigo can confirm

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Feb 6, 2025

Please add the FINISHED info after confirming with @wendigo and squash the commits

@github-actions github-actions bot added release-notes ui Web UI jdbc Relates to Trino JDBC driver hudi Hudi connector iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector bigquery BigQuery connector mongodb MongoDB connector snowflake Snowflake connector cassandra Cassandra connector blackhole Blackhole connector clickhouse ClickHouse connector druid Druid connector duckdb DuckDB connector elasticsearch Elasticsearch connector exasol Exasol connector faker Faker connector google-sheets Google Sheets connector ignite Ignite connector kafka Kafka connector loki Loki connector mariadb MariaDB connector memory Memory connector labels Feb 8, 2025
@ebyhr ebyhr removed release-notes ui Web UI jdbc Relates to Trino JDBC driver hudi Hudi connector iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector bigquery BigQuery connector mongodb MongoDB connector snowflake Snowflake connector cassandra Cassandra connector blackhole Blackhole connector clickhouse ClickHouse connector druid Druid connector duckdb DuckDB connector elasticsearch Elasticsearch connector exasol Exasol connector faker Faker connector google-sheets Google Sheets connector ignite Ignite connector kafka Kafka connector loki Loki connector mariadb MariaDB connector memory Memory connector mysql MySQL connector labels Feb 9, 2025
Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me .. @wendigo ?

Comment thread docs/src/main/sphinx/client/client-protocol.md
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Feb 10, 2025

Ufff. .. I should have squashed these commits .. in the future @EdenKik please keep things like this all in one commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants