HBase Connection Registry usage with Phoenix JDBC url#24869
HBase Connection Registry usage with Phoenix JDBC url#24869mosabua merged 1 commit intotrinodb:masterfrom
Conversation
|
I have run Edit: updated test to use new format for ZK ConnectionRegistry. RPC Registry for test is facing errors because in docker env, clients can exhaust master with RPC threadpool while it is already running in-house chores. |
virajjasani
force-pushed
the
reg
branch
5 times, most recently
from
2cfd35e to
9f24500
Compare
|
Looks good. +1 |
|
Thanks @lhofhansl! FYI @stoty if you would also like to take a look. |
|
LGTM. Note that in most cases the default jdbc:phoenix URL should be used, as the cluster can be determined from the hbase / hadoop config files that must be present on the classpath anyway for for correct operation. |
There was a problem hiding this comment.
The connection URL for Phoenix set with phoenix.connection-url supports multiple formats:
There was a problem hiding this comment.
Connection URL:
| ### `phoenix.connection-url` | |
| ### Connection URL: |
There was a problem hiding this comment.
Change this whole list into an item list and wrap at 80 char width so we can actually review wording.
Like
* `jdbc:phoenix[:zk_quorum][:zk_port][:zk_hbase_path][:principal][:keytab][;options]`:
Connection uses HBase Zookeeper Registry. The `zk_quorum` is a comma separated
list of ZooKeeper servers. The `zk_port` is the ZooKeeper port. The
`zk_hbase_path` is the HBase root znode path, that is configurable using
`hbase-site.xml`. By default the location is `/hbase`. Principal, Keytab and
Options are optional.
* `jdbc:phoenix+zk[:host1\:port1][,:host2\:port2]...[,:hostN\:portN][:zk_hbase_path][:principal][:keytab][;options]`:
Uses same Connection as above, however host:port pairs are separated by comma.
...
There was a problem hiding this comment.
| | `phoenix.connection-url` | Yes | Detailed description: [](phoenix-connection-url). | | |
| | `phoenix.connection-url` | Yes | See [](phoenix-connection-url). | |
There was a problem hiding this comment.
Ideally we change this whole list into a list-table .. but that could be a separate commit before or after .. or even a separate PR
virajjasani
force-pushed
the
reg
branch
2 times, most recently
from
9024a1a to
d09425c
Compare
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Ready to go after the minor nits are fixed
There was a problem hiding this comment.
| ### Connection URL: | |
| ### Connection URL |
5 participants
Description
Use various HBase Connection Registries with Phoenix JDBC url formats. Document with recommendations and use in test.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.