Skip to content

Clarify requirements for Azure Storage file system support #24864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2025
Merged

Clarify requirements for Azure Storage file system support #24864

merged 1 commit into from
Feb 3, 2025

Conversation

@Joelg96
Copy link
Contributor

@Joelg96 Joelg96 commented Jan 31, 2025

Description

  • Added clarifying requirement for the storage account.
  • Changed link to Azure documentation - from main page to ADLS overview page.

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jan 31, 2025
@github-actions github-actions bot added the docs label Jan 31, 2025
mosabua
mosabua reviewed Jan 31, 2025
View reviewed changes
@Joelg96 Joelg96 force-pushed the jg/Add-ADLS-requirement-for-native-FS branch from 7d14771 to c513ca3 Compare February 3, 2025 18:01
@mosabua
Copy link
Member

mosabua commented Feb 3, 2025 •
edited
Loading

Please rebase and squash commits

@Joelg96 Joelg96 force-pushed the jg/Add-ADLS-requirement-for-native-FS branch from c513ca3 to fa2a4ae Compare February 3, 2025 20:58
@github-actions github-actions bot added release-notes iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector faker Faker connector loki Loki connector mysql MySQL connector redis Redis connector labels Feb 3, 2025
@Joelg96 Joelg96 force-pushed the jg/Add-ADLS-requirement-for-native-FS branch from fa2a4ae to 7dfc20f Compare February 3, 2025 21:33
@Joelg96 Joelg96 removed release-notes iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector faker Faker connector loki Loki connector mysql MySQL connector redis Redis connector labels Feb 3, 2025
@mosabua
Copy link
Member

mosabua commented Feb 3, 2025

Please update commit message and PR title to

Clarify requirements for Azure Storage file system support

@Joelg96 Joelg96 changed the title Add ADLS requirement clarification to native FS doc Clarify requirements for Azure Storage file system support Feb 3, 2025
@Joelg96 Joelg96 force-pushed the jg/Add-ADLS-requirement-for-native-FS branch from 7dfc20f to 4036e5e Compare February 3, 2025 21:42
mosabua
mosabua approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thank you @Joelg96

@mosabua mosabua merged commit e411f9a into trinodb:master Feb 3, 2025
5 of 8 checks passed
@github-actions github-actions bot added this to the 470 milestone Feb 3, 2025
@mosabua mosabua mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mosabua mosabua mosabua approved these changes

@anusudarsan anusudarsan Awaiting requested review from anusudarsan

Assignees

No one assigned

Labels

cla-signed docs

Milestone

470

Development

Successfully merging this pull request may close these issues.

2 participants

@Joelg96 @mosabua